Repository navigation
K2GO-577 feat(share): resume a cut ZIM share and close the session on Done - #783
Closed
luisguzman-adfa wants to merge 3 commits into
Closed
luisguzman-adfa wants to merge 3 commits into
luisguzman-adfa wants to merge 3 commits into
Conversation
The sender's close DELETE lost its token in the relay and got 401, so the share stayed open after Done.
…ZIM MD5 on import Retry of a cut share item restarted at byte 0. A resumed file must not reach the library unless its own checksum matches.
The receiver keeps a cut exact-file item as a partial keyed by its ZIM UUID and continues it with Range, so a large item does not restart at 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
/v1relay forwardsX-Share-Tokento conex-core (never logged).Range: bytes=N-for a direct item (ZIM) and answers 206 withContent-Range. The Kiwix import checks the ZIM's own MD5 while it copies and replaces the target only on a match (codecorruptotherwise).Accept-Ranges: bytes). Rules incontentexchange/domain/PartialPayload(JVM tests).Why
Steps to QA
Verifications
Notes