Repository navigation
K2GO-578 feat(contentexchange): Share and Receive screens: invite as text, Receive start screen, pinned Share layout - #784
Merged
Conversation
The Share invite shows as copyable text under its QR, and Receive takes a pasted invite through the same ShareHandshake.decode as a scan. This lets phones without a working camera, or a remote device tunnel, share content. Clone and Content Exchange now use one shared code-as-text block (view_k2go_code_text, view_k2go_code_paste, CodeText).
The scan and the enter-as-text path were squeezed into the Content manager bottom bar. A dedicated start screen, modelled on Clone's Receive, lays out join Wi-Fi, scan, and paste as two steps.
…d code-path helper Share: back header, count and size, and the transport strip stay at the top; Done stays at the bottom; the invite step is named Share and numbered by the visible steps. CodeText owns the scan options, Wi-Fi settings and the paste block for Clone and Content Exchange; the step header and the bottom bar are one layout and one style.
…ne-code / two-code wording
Drops k2go_cx_share_receive_caption ("Then scan..."), wrong when the Wi-Fi transport shows a single step.
…, not "Clone" The layout serves Clone, Connect and Share; reuse qr_content_description.
… to screen readers Connect Wi-Fi QR reads "Open the library" (as its Hotspot twin); Clone transfer QR reads "QR Code".
…"N selected : size" line Drops the untranslated k2go_cx_share_summary plural and the unused k2go_cx_share_subtitle_fmt.
…e, like Done A share left running made the next Share reopen it and ignore the new selection.
… screens No "Ready! Scan" caption while the invite QR is pending; Share size sums the selected items; scanner registered once; shared code layouts on the 4dp grid.
…t stops the share Reuses Clone's "Stop sharing?" dialog; Back is easy to hit mid-transfer.
…e loses its progress Resume is not guaranteed for every app yet, so the Share dialog does not reuse Clone's "can start again" text. New string in all locales.
Collaborator
Author
|
Light mode verified on the OnePlus 7T: Receive content, Share content and the "Stop sharing?" dialog read correctly. The subtitle format above is "N selected : size" (for example "1 selected : 52 KB"). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
k2go_cx_share_stop_msg"This stops any copy in progress. The other phone loses its progress and must start again with a new code." (all locales)k2go_cx_selected_fmt)k2go_cx_share_subtitle_fmt,k2go_cx_share_receive_captionWhy
Steps to QA
Verifications
Notes