Skip to content

K2GO-564 feat(ci): Play upload signs in keyless with Workload Identity Federation - #791

Merged
luisguzman-adfa merged 1 commit into
mainfrom
feat/K2GO-564-play-keyless-auth
Nov 16, 2026
Merged

luisguzman-adfa merged 1 commit into
mainfrom
feat/K2GO-564-play-keyless-auth

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • play-candidate.yml: signs in to Google Play with Workload Identity Federation (google-github-actions/auth@v3, id-token: write). One token before Plan and a fresh one before Send, because a token lasts one hour and the build sits between them. No credentials file on the runner.
  • play_publish.py: reads the token from PLAY_ACCESS_TOKEN. The service account JSON key path (JWT signed with openssl) is removed.
  • ADR-K2GO-564, point 5: describes the keyless credentials.

Why

  • The organization blocks service account keys (iam.disableServiceAccountKeyCreation is enforced), so PLAY_SERVICE_ACCOUNT_JSON cannot exist. Keyless sign-in also leaves no secret to leak or rotate.

Steps to QA

  • Baseline: on main, play-candidate needs PLAY_SERVICE_ACCOUNT_JSON, which does not exist, so the Play API steps fail.
  • Change: after merge, run play-candidate from main on track internal and approve the google-play environment. Both sign-in steps pass, and the build shows in Play Console > Internal testing.

Verifications

  • test_play_publish: 26 tests pass. Workflow YAML parses.
  • Google side is set up: robot k2go-play-publisher (no keys), WIF pool github-actions / provider knowledgetogo-repo (only this repo in environment google-play), STS and IAM Credentials APIs on, robot invited in Play Console (Knowledge to Go only, testing tracks).
  • Coordination: the GitHub environment google-play must exist (with a required reviewer) before the first run.

Notes

…y Federation

The organization blocks service account keys. play-candidate gets a one-hour token for the
k2go-play-publisher robot through google-github-actions/auth, and play_publish.py reads it from
PLAY_ACCESS_TOKEN. The JSON key path is removed.
@luisguzman-adfa
luisguzman-adfa merged commit ee5b1d2 into main Nov 16, 2026
3 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the feat/K2GO-564-play-keyless-auth branch November 16, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant