Repository navigation
K2GO-577 feat(hotspot): one Hotspot / Wi-Fi rule for Connect, Clone and Share - #792
Open
luisguzman-adfa wants to merge 4 commits into
Open
luisguzman-adfa wants to merge 4 commits into
luisguzman-adfa wants to merge 4 commits into
Conversation
…nd Share HotspotMode holds a screen's choice: Hotspot takes its hold on the shared hotspot, Wi-Fi gives it back. Share no longer starts the hotspot on its own. Connect warns before Wi-Fi drops joined devices. WifiQr and QrSection.setWifiJoin build the escaped join QR in one place.
…ddress clash A sender on the shared Wi-Fi no longer cuts Connect. The Connect switch warning ships in all locales.
…arn only on a real drop The switch warning asks the hotspot owner whether this screen is its last holder. The share notification no longer claims a hotspot on Wi-Fi.
…O-577-share-transport-mode
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
HotspotMode) for Connect, Clone and Content Exchange Share. Hotspot holds the shared hotspot. Wi-Fi gives it back.WifiQr) and one join section (QrSection.setWifiJoin) for Connect, Clone, Share and the QR screen.k2go_connect_switch_msg"Devices joined to this hotspot lose their connection." (33 locales).k2go_cx_share_notif_open, 33 locales).k2go_cx_share_need_permission(no longer used).Why
;,:,,,"and\.Steps to QA
adb shell dumpsys wifip2p | grep groupFormed-> true).Verifications
HotspotModeTest,WifiQrTest,HotspotHoldersTest), lint clean.Notes