Skip to content

K2GO-579 fix(privacy): crash reports are off by default in every build - #794

Merged
luisguzman-adfa merged 1 commit into
mainfrom
fix/K2GO-579-crash-reports-off-by-default
Nov 17, 2026
Merged

luisguzman-adfa merged 1 commit into
mainfrom
fix/K2GO-579-crash-reports-off-by-default

Conversation

@luisguzman-adfa

Copy link
Copy Markdown
Collaborator

What changes

  • Crash reports (GlitchTip, Sentry SDK) are off by default in every build. CrashReportConsent defaults to false.
  • The build-time default CRASH_REPORTS_DEFAULT_ON (true in defaultConfig, false in fdroid) is removed: one value now decides it for all builds.
  • UI changes: Settings > About > "Send crash reports" shows OFF on a new install, and after an update for users who never touched it. No string changes. An explicit user choice is kept.

Why

  • "Keep offline" turned off usage analytics only. GlitchTip still started and could connect, so a user who chose "Keep offline" still sent data. Raised by David Schachter on the wiki (Play APK origin, comment).
  • K2GO-523 sets the rule: when the user declines, K2Go makes no external connection other than user-initiated downloads.

Steps to QA

  • Baseline (main): new install, "Keep offline". Settings > About > "Send crash reports" is ON and Sentry starts at launch.
  • Change: new install, "Keep offline". The toggle is OFF and Sentry does not start. Turn it on, restart: Sentry starts.

Verifications

  • Unit tests: 1278 pass. The standard, play and fdroid flavors compile.
  • Both Sentry entry points (startup init in IIABApplication, DiskGuard capture) already check CrashReportConsent, so the default covers both.
  • Evidence (device before and after) goes in Jira K2GO-579.

Notes

  • Related: K2GO-523, K2GO-401, K2GO-559.

"Keep offline" turned off analytics only, so GlitchTip still connected. Crash reports
now stay off until the user turns them on; the per-flavor default is removed.
@luisguzman-adfa luisguzman-adfa added the ui change or edit to UI label Nov 17, 2026
@luisguzman-adfa
luisguzman-adfa merged commit bd8f98f into main Nov 17, 2026
4 checks passed
@luisguzman-adfa
luisguzman-adfa deleted the fix/K2GO-579-crash-reports-off-by-default branch November 17, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui change or edit to UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant