Repository navigation
ADFA-6683: Store documentation pages in compressed blocks (schema 4.0.0) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidschachterADFA
wants to merge
17
commits into
main
Choose a base branch
from
fix/ADFA-6683
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0a0ec4e
ADFA-6683: Store a/, j/ and k/ pages N to a compressed block (prototype)
davidschachterADFA ac11493
ADFA-6683: Record the measured saving; say --pack ContentBlocks renum…
davidschachterADFA 670095f
ADFA-6683: Refuse a 4.x database in the re-mint and its verifier
davidschachterADFA 1bb6afe
ADFA-6683: Block five sets, items up to 1 MiB, blocks up to 4 MiB, 64…
davidschachterADFA 8650521
ADFA-6683: Declare 4.0.0, and run only on a database declaring 3
davidschachterADFA 17ef48a
ADFA-6683: Run the blocks tests in CI; describe schema 4.0.0 in CLAUD…
davidschachterADFA 6c88cbe
ADFA-6683: Test the decode window, the write-ahead limit and every st…
davidschachterADFA 7d2424a
ADFA-6683: Re-mint pair refuses block tables whatever the version; re…
davidschachterADFA e213338
ADFA-6683: Correct CLAUDE.md on 4.x tools, ship-time packs and the re…
davidschachterADFA 9313890
ADFA-6683 | Say j/ takes templated javadoc JSON rows too; test one
davidschachterADFA 5a54168
ADFA-6683 | CLAUDE.md: the Drive master will be 4.0.0, so the ship-ti…
davidschachterADFA 7b92606
ADFA-6683 | CLAUDE.md: list the tools a 4.0.0 database breaks, with w…
davidschachterADFA aa4f43f
ADFA-6683 | CLAUDE.md: drop_unread_rows.py exits 0 with nothing to dr…
davidschachterADFA 9c09446
ADFA-6683 | verify_remint_dictionary.py: close both databases when a …
davidschachterADFA 7a3d63b
ADFA-6683 | store_pages_in_blocks.py: check the writes against what w…
davidschachterADFA bd39a9e
ADFA-6683 | CLAUDE.md: the Drive master stays 3.x until ADFA-6871; th…
davidschachterADFA 583987f
ADFA-6683 | CLAUDE.md: the Drive master is 2.x, and the build order c…
davidschachterADFA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This compares
declared_major()with an int, but this file'sdeclared_major(line 191) returnsrow[0]as stored. The new copy inoptimize_db_media.pywraps it inint(). If the major is ever stored as TEXT,major >= CONTENT_BLOCKS_FROM_MAJORraisesTypeError, and the re-mint and its verifier end in a traceback instead of the refusal. Could this use the shareddeclared_major, or addint()here?