Skip to content

Fix Publish addons: drop Share-Your-Apps duplicate LICENSE and check for it - #164

Merged
hal-eisen-adfa merged 2 commits into
mainfrom
fix/share-your-apps-duplicate-license
Nov 13, 2026
Merged

hal-eisen-adfa merged 2 commits into
mainfrom
fix/share-your-apps-duplicate-license

Conversation

@hal-eisen-adfa

@hal-eisen-adfa hal-eisen-adfa commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Publish addons run 43349501901 fails in Build the source tarballs:

RuntimeError: Share-Your-Apps: LICENSE is claimed twice

tools/addons/src/addons/tarball.py copies the addon's tracked files to the archive root and then injects the repository's root LICENSE at the same path. plugins/Share-Your-Apps/LICENSE is the only addon-level LICENSE in the repo, so it collides. The crash also stopped the remaining tarballs, catalog generation and the R2 publish.

The nested server/ project is not involved; its LICENSE stages at server/LICENSE.

Changes

  • Delete plugins/Share-Your-Apps/LICENSE.
  • addons check now fails a plugin that tracks a root LICENSE, so this is caught on the PR by Check toolchain instead of at publish time. Test added in tests/test_check.py.

Verification

  • addons check passes; with the old LICENSE restored it fails with Share-Your-Apps: LICENSE at the addon root clashes with the repository LICENSE the source tarball adds; delete it.
  • pytest: 135 passed.
  • addons tarball --only plugins/Share-Your-Apps now builds share-your-apps-src.tar.gz, containing LICENSE (from repo root) and server/LICENSE.

Open question (not changed here)

The removed file was AGPL-3.0; the repository root LICENSE is GPL-3.0, while the plugin README and the comment in tarball.py both say AGPL. Someone should confirm which licence is intended.

addons tarball injects the repository LICENSE at the archive root, so an
addon-level LICENSE at the same path makes _claim() raise
'Share-Your-Apps: LICENSE is claimed twice' and aborts Publish addons
(run 43349501901). The tarball still ships LICENSE from the repo root.
The source tarball adds the repository LICENSE at the archive root, so
an addon-level copy aborts Publish addons with 'LICENSE is claimed
twice'. Catch it on the pull request instead of at publish time.
@hal-eisen-adfa hal-eisen-adfa changed the title Fix Publish addons: drop Share-Your-Apps duplicate LICENSE Fix Publish addons: drop Share-Your-Apps duplicate LICENSE and check for it Nov 13, 2026
@hal-eisen-adfa
hal-eisen-adfa merged commit de0a34c into main Nov 13, 2026
1 check passed
@hal-eisen-adfa
hal-eisen-adfa deleted the fix/share-your-apps-duplicate-license branch November 13, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant