Repository navigation
ADFA-6655 | Update Icons Repository to upstream 2.0.3 and add in-app help - #165
Open
jimturner-adfa wants to merge 5 commits into
Open
jimturner-adfa wants to merge 5 commits into
jimturner-adfa wants to merge 5 commits into
Conversation
Copy src/ verbatim from omar-haidar/IconsRepository-Plugin at e083ffa (2026-10-22). The addons copy was last synced from upstream 252e73a (2026-05-19). Upstream adds a view-model layer, ModuleDiscoveryEngine, IconImportDialogManager and FastSearchIndexV2, and moves models/ and repository/ under data/. This commit is the unmodified upstream source only, so the next commit shows exactly what addons changes on top. It drops the addons lifecycle fixes and manifest entries; the next commit restores them. Build files are untouched here, so this commit alone does not build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream e083ffa never picked up the addons lifecycle fixes, so restore
them against the new layout:
- BasePlugin.dispose() drops the project service and plugin context.
- Main.dispose() shuts down IconRepository and clears the static
instance; IconRepository gains shutdown().
- IconsAdapter owns the SVG render pool and bitmap cache (upstream keeps
them static in IconViewHolder, so they outlive every adapter) and
releases them, plus any pending search, on detach.
Manifest: display name "Icons Repository", version from
${pluginVersion}, plugin.max_ide_version 26.99 (min stays at upstream's
26.42) and plugin.editor_tabs, since Main contributes an editor tab.
Build: pluginVersion/versionName 2.0.3, recyclerview added and
material/appcompat raised to upstream's versions. Keeps the addons build
setup: shared ../../libs jars, no aliyun mirrors or mavenLocal(). Upstream
SvgToVectorImporter already guards readAllBytes by SDK level, which
replaces the ADFA-5707 Utils helper. README and doc page updated for the
new version range and module layout.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
IconsAdapter releases its search and render executors in onDetachedFromRecyclerView, but RecyclerView only calls that when the adapter is removed. MainFragment never removed it, so every reopened tab leaked a 4-thread render pool and a search thread. Remove the adapter and the search text watcher in onDestroyView. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The plugin had no tooltips or offline help (review clause 6.7): the side menu item's tooltip tag was the literal "No tooltip" and the editor tab's was "No description". Main now implements DocumentationExtension under the category "plugin_dev.omar.plugin.iconsrepo". New help.IconsRepositoryHelp holds a Tier 1 summary and Tier 2 detail for the side-menu item, the search field, the icon grid and each import-dialog control (preview, name, module, color, Import/Cancel), plus long-press wiring through the 3-argument IdeTooltipService.showTooltip. Text fields get the tooltip on their start and end icons, so a long-press in the text still selects text. Every entry links to a Tier 3 guide at assets/docs/index.html, which covers search, the import fields, what file gets written and where, and that an import silently replaces a drawable with the same name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On device (Code on the Go release C-r-1112-1729), the search, icon name and hex color fields rendered without the start and clear icons their layouts declare with app:startIconDrawable / app:endIconMode, so the tooltips wired to those icons had nothing to long-press. The cause was not pinned down: other app: attributes in the same layouts (card corner radius, stroke) do apply. Set the start icon and clear-text end icon in code before wiring the tooltips. Verified on a Pixel 6 Pro: the icons appear, the clear button works, and long-press shows each field's tooltip. Also mention the preview in the import tooltip's summary, since the preview shares that entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-6655
Updates the Icons Repository plugin to the contributor's current version (GitHub issue appdevforall/CodeOnTheGo#2165), keeps the addons fixes upstream never picked up, and adds the in-app help the plugin never had.
Summary
Review by commit — the first is a verbatim import, the rest are ours:
e083ffa—src/copied unchanged from omar-haidar/IconsRepository-Plugin (2026-10-22). The addons copy was last synced from252e73a(2026-05-19). Upstream adds a view-model layer,ModuleDiscoveryEngine, an import-dialog manager and a faster search index. Does not build on its own.dispose()releases the project service, context, repository executor and static instance; the render pool and bitmap cache move from statics inIconViewHolderto the adapter. Manifest: display name,${pluginVersion}(2.0.3),plugin.max_ide_version26.99 (min is upstream's 26.42) andplugin.editor_tabs. Keeps the addons build setup (shared../../libs, no aliyun mirrors ormavenLocal()). Upstream's SDK-guardedreadAllBytesreplaces the ADFA-5707 helper.onDestroyView— RecyclerView only callsonDetachedFromRecyclerViewwhen the adapter is removed, so the executors were never shut down and every reopened tab leaked a 4-thread pool. Present before this PR too.MainimplementsDocumentationExtension(categoryplugin_dev.omar.plugin.iconsrepo); Tier 1/2 entries for the side-menu item, search, icon grid and every import-dialog control, wired with the 3-argshowTooltip; Tier 3 guide atassets/docs/index.html. Replaces the placeholder"No tooltip"/"No description".app:startIconDrawable/app:endIconMode, leaving their tooltips unreachable. Root cause not found (otherapp:attributes in the same layouts do apply).Not taken from upstream: its committed signing material, its bundled
libs/*.jar,.idea/,.github/.Testing
assemblePluginbuilds;addons checkpasses./plugin-reviewrubric: all clauses pass after commit 4 (6.7 was Fail before).C-r-1112-1729:n/a) on the side-menu item, search icon and clear button, an icon tile, the preview, name, module, color, hex field, Import and Cancel; "See more" and the guide link work offline.home); import withcolorPrimarywrites?attr/colorPrimary, custom#FF6200EEwrites that tint;Bad_Nameand an empty hex are rejected and nothing is written.Known limitations
EditorTabItem.tooltipthere.🤖 Generated with Claude Code