Repository navigation
feat: let embedders search only the sealed class's package for inheritors - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLSealedInheritorsProviderasksKotlinDirectInheritorsProvider.getDirectKotlinInheritorsfor every inheritor in the module, then keeps only those in the sealed class's package. In CodeOnTheGo the full search parses every source file on each call. Searching only the package cut the first completion after a cold open from 26.9 s to 14.5 s on a moto g34.This patch:
KotlinDirectInheritorsProvider.getSamePackageDirectKotlinInheritors, a default method that filtersgetDirectKotlinInheritorsto the base class's package;LLSealedInheritorsProvidercall it, instead of filtering itself.With the default, behaviour is unchanged. An embedder that can list a package's files overrides it;
getDirectKotlinInheritorskeeps its "all inheritors in scope" contract.Adds
patches/0012-feat-let-embedders-search-only-the-sealed-class-s-pa.patch. Patches 0001-0011 are unchanged.Built locally on 2.3.20 with patches 0001-0012.
javapshows the default method andLLSealedInheritorsProvidercalling it. CoGo's:lsp:kotlinunit tests: 653/653 with the override in use (ADFA-6857).