ci: replace Thor releases with Release Please and trusted publishing - #259
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
appium_thorrelease tasks with Release Please and RubyGems Trusted Publishing, following appium/ruby_lib_core#704. Maintainers review and merge a release PR; version, date, changelog, tag, GitHub Release, and publication are automated.GITHUB_TOKENand explicit workflow dispatch; no custom GitHub App or PAT.ruby-release-validateaction from feat: add shared Ruby release validation action appium-workflows#12, pinned to its merged commit, for PR and tagged-package validation. No duplicated helper or helper tests remain here.pkg/directory and authenticates using OIDC.thorandarc. Fix the obsolete RuboCop cop name so lint can run. The oldthor spectask referred to a nonexistent spec directory.Validation
Local gem build, shared action validation on the built artifact, simulated artifact filename transfer between jobs, actionlint, and whitespace checks passed. The shared validator has passing Ruby 3.1/3.4/4.0 tests in its own repository. The initial migration also passed local library/lint or CLI smoke checks, as applicable. No gem was published or remote publication settings changed.
Activation
Allow Actions to create PRs, create the
rubygemsGitHub environment, and register a Trusted Publisher on appium_console with ownerappium, repositoryruby_console, workflowpublish-gem.yml, and environmentrubygems. The shared composite action does not change this registration. SeeRELEASING.mdfor required checks and limitations of event-only PR checks.Together with the other Ruby migrations, this removes release dependencies on
appium_thorso it can subsequently be deprecated.