Skip to content

fix: SDK update for version 29.3.1 - #175

Merged
ChiragAgg5k merged 1 commit into
29.xfrom
release-29.3.1
Oct 12, 2026
Merged

ChiragAgg5k merged 1 commit into
29.xfrom
release-29.3.1

Conversation

@ChiragAgg5k

Copy link
Copy Markdown
Member

This PR contains updates to the SDK for version 29.3.1.

What's Changed

  • Fixed: added ProjectAuthMethodId.Passkey, so project.updateAuthMethod can enable passkeys
  • Fixed: added ProjectPolicyId.Passkey and the Models.PolicyPasskey model, so getPolicy and listPolicies return the passkey policy

Completes the passkeys release: 29.3.0 shipped the passkey methods, but not the passkey auth method and policy IDs or the PolicyPasskey model, so the SDK could not enable passkeys on a project. Made from a spec with exactly these pieces removed, three-way merged onto 29.x. Build and all 903 jest tests pass.

@hansi-codes

hansi-codes Bot commented Oct 12, 2026

Copy link
Copy Markdown

🔵 Tier A · Mergeable after minor fixes

The passkey lookup test still targets the password-dictionary path, leaving a minor coverage gap to fix.

This updates the SDK version to 29.3.1 and adds the passkey auth-method and policy identifiers. It also adds the passkey policy model to the policy response types and updates the changelog.

Verdict New comments Fixed Still open
✅ Approved 1 0 0
Finding Where
🟡 Test still exercises password-dictionary, not passkey test/services/project.test.js:1943
Fix with agent prompt
### Issue 1
test/services/project.test.js:1943-1944
**Test still exercises password-dictionary, not passkey**

This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
📂 Walkthrough · 7
File Change
CHANGELOG.md Documents the 29.3.1 passkey SDK additions.
package.json, package-lock.json Bumps package metadata to version 29.3.1.
src/client.ts Updates the SDK version in request metadata and the user agent.
src/enums/project-auth-method-id.ts, src/enums/project-policy-id.ts Adds the passkey auth-method and policy enum values.
src/models.ts Defines the passkey policy model and includes it in policy-list types.
src/services/project.ts Adds the passkey policy model to getPolicy return types.
test/services/project.test.js Changes the getPolicy response fixture to passkey-shaped fields.

Reviewed b1ba6a7 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · Looks good to merge. Summary

Comment on lines +1943 to +1944
rpId: 'example.com',
origins: [],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test still exercises password-dictionary, not passkey

This fixture has passkey fields, but the test still calls getPolicy('password-dictionary') and its $id remains password-dictionary. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/project.test.js
Line: 1943-1944

Comment:
**Test still exercises password-dictionary, not passkey**

This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

🟡 Minor · testing · Reply if this doesn't apply.

@ChiragAgg5k
ChiragAgg5k merged commit 037a6d1 into 29.x Oct 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant