Repository navigation
fix: SDK update for version 29.3.1 - #175
Conversation
🔵 Tier A · Mergeable after minor fixes
This updates the SDK version to 29.3.1 and adds the passkey auth-method and policy identifiers. It also adds the passkey policy model to the policy response types and updates the changelog.
Fix with agent prompt### Issue 1
test/services/project.test.js:1943-1944
**Test still exercises password-dictionary, not passkey**
This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.📂 Walkthrough · 7
Reviewed |
| rpId: 'example.com', | ||
| origins: [], |
There was a problem hiding this comment.
Test still exercises password-dictionary, not passkey
This fixture has passkey fields, but the test still calls getPolicy('password-dictionary') and its $id remains password-dictionary. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/services/project.test.js
Line: 1943-1944
Comment:
**Test still exercises password-dictionary, not passkey**
This fixture has passkey fields, but the test still calls `getPolicy('password-dictionary')` and its `$id` remains `password-dictionary`. It will pass without ever exercising a passkey lookup, so it does not verify the newly added policy path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.🟡 Minor · testing · Reply if this doesn't apply.
This PR contains updates to the SDK for version 29.3.1.
What's Changed
ProjectAuthMethodId.Passkey, soproject.updateAuthMethodcan enable passkeysProjectPolicyId.Passkeyand theModels.PolicyPasskeymodel, sogetPolicyandlistPoliciesreturn the passkey policyCompletes the passkeys release: 29.3.0 shipped the passkey methods, but not the
passkeyauth method and policy IDs or thePolicyPasskeymodel, so the SDK could not enable passkeys on a project. Made from a spec with exactly these pieces removed, three-way merged onto29.x. Build and all 903 jest tests pass.