Repository navigation
fix: resolve Apple UIKit example against local SDK - #2142
Merged
Merged
Conversation
🟢 Tier S · Ready to merge
The UIKit example project now registers the containing Apple SDK as a local Swift package and points its folder reference at that SDK. The resolved lockfile refreshes the swift-collections and swift-log pins, and a generation regression verifies that the local package reference resolves to the generated SDK manifest.
📂 Walkthrough · 3
Reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UIKit example had no registered local Swift package and referenced
../../../examples/apple, so resolving it could succeed with an empty dependency graph. Register the containing SDK (..) as a local package and use the same path for the project folder reference.Refresh the Xcode-generated lockfile to the current 23-package graph, including swift-collections 1.7.4 and swift-log 1.16.2. A generation regression verifies that the registered reference resolves to the generated SDK manifest; it fails against the previous project template.
Validation:
The simulator build compiles the dependencies but fails in unchanged UIKit sample code (obsolete
Database/account APIs and asynchronous@IBActionhandlers). Those existing sample-code repairs are outside this dependency refresh.Published SDK propagation: appwrite/sdk-for-apple#134. Security tracker: https://github.com/appwrite-labs/cloud/issues/6887
Tracks appwrite-labs/cloud#6887