Repository navigation
fix(ci): read Hansi's tier from its check run on the head commit - #2170
Conversation
The summary comment footer reads "Reviewed the commits since <old sha>" on incremental reviews, so a re-reviewed PR never matched the head commit and could not automerge. The Hansi check run is attached to the exact commit and its title carries the tier.
🟢 Tier S · Ready to merge
The automerge workflow reads Hansi’s tier from the completed check run on each open Renovate PR’s current head commit, then checks CI status and approval before merging tier S PRs. It also uses Hansi’s PR comment as the event that starts the workflow, alongside the existing scheduled and CI completion triggers. Latest changes: The newest commit switches the wake-up event back from check-run completion to Hansi’s PR comment, avoiding reliance on a check-run event that may be suppressed.
📂 Walkthrough · 1
✅ Fixed since the last review · 1
Reviewed the commits since |
GitHub never fires check_run workflows for a head SHA that already has GitHub Actions check suites, which every Renovate head has.
What
The automerge workflow now takes Hansi's verdict from the
Hansicheck run on the PR's head commit (titleTier S: Ready to merge) instead of parsing the summary comment. It still triggers on Hansi's summary comment, which is edited when a review completes: GitHub never firescheck_runworkflows for a head SHA that has GitHub Actions check suites, so the check run itself can't be the trigger.Why
On incremental reviews the summary comment footer reads
Reviewed the commits since <old sha>rather thanReviewed <head sha>, so any Renovate PR that received a follow-up push (e.g. #2133) could never match its head commit and would never automerge. The check run is attached to the exact commit Hansi reviewed, so it needs no SHA parsing.Verification
actionlintpasses. Dry run against the live PRs:The Hansi check run on #2162's merged head (
f80346a) has the titleTier S: Ready to merge, which the new check accepts.Related: appwrite-labs/cloud#6670