Skip to content

fix(ci): read Hansi's tier from its check run on the head commit - #2170

Merged
ChiragAgg5k merged 2 commits into
mainfrom
fix/automerge-hansi-check-run
Oct 29, 2026
Merged

ChiragAgg5k merged 2 commits into
mainfrom
fix/automerge-hansi-check-run

Conversation

@ChiragAgg5k

@ChiragAgg5k ChiragAgg5k commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

What

The automerge workflow now takes Hansi's verdict from the Hansi check run on the PR's head commit (title Tier S: Ready to merge) instead of parsing the summary comment. It still triggers on Hansi's summary comment, which is edited when a review completes: GitHub never fires check_run workflows for a head SHA that has GitHub Actions check suites, so the check run itself can't be the trigger.

Why

On incremental reviews the summary comment footer reads Reviewed the commits since <old sha> rather than Reviewed <head sha>, so any Renovate PR that received a follow-up push (e.g. #2133) could never match its head commit and would never automerge. The check run is attached to the exact commit Hansi reviewed, so it needs no SHA parsing.

Verification

actionlint passes. Dry run against the live PRs:

#2133: no Hansi tier S review for f7dadeae615f590dce434181dfa19a845ac10111 (Tier A: Mergeable after minor fixes)

The Hansi check run on #2162's merged head (f80346a) has the title Tier S: Ready to merge, which the new check accepts.

Related: appwrite-labs/cloud#6670

The summary comment footer reads "Reviewed the commits since <old sha>" on incremental reviews, so a re-reviewed PR never matched the head commit and could not automerge. The Hansi check run is attached to the exact commit and its title carries the tier.
@hansi-codes

hansi-codes Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

🟢 Tier S · Ready to merge

The latest change restores the Hansi comment trigger, resolving the open concern that check-run completions may not start the workflow.

The automerge workflow reads Hansi’s tier from the completed check run on each open Renovate PR’s current head commit, then checks CI status and approval before merging tier S PRs. It also uses Hansi’s PR comment as the event that starts the workflow, alongside the existing scheduled and CI completion triggers.

Latest changes: The newest commit switches the wake-up event back from check-run completion to Hansi’s PR comment, avoiding reliance on a check-run event that may be suppressed.

Verdict New comments Fixed Still open
✅ Approved 0 1 0
📂 Walkthrough · 1
File Change
.github/workflows/automerge.yml Uses Hansi’s PR comment to trigger automerge while looking up the tier from the Hansi check run on the current Renovate head commit.
✅ Fixed since the last review · 1
  • Hansi check completions may not trigger this workflow · .github/workflows/automerge.yml:7

Reviewed the commits since a60b6c0 · Details · Comment @hansi-codes review to re-run, or mention @hansi-codes with a question.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Tier A · See the inline comments. Summary

Comment thread .github/workflows/automerge.yml Outdated
GitHub never fires check_run workflows for a head SHA that already has GitHub Actions check suites, which every Renovate head has.

@hansi-codes hansi-codes Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tier S · Looks good to merge. Summary

@ChiragAgg5k
ChiragAgg5k merged commit 679c2a2 into main Oct 29, 2026
60 checks passed
@ChiragAgg5k
ChiragAgg5k deleted the fix/automerge-hansi-check-run branch October 29, 2026 13:39
@ChiragAgg5k ChiragAgg5k self-assigned this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant