Skip to content
This repository was archived by the owner on Jul 7, 2026. It is now read-only.

feat: GitHub and Sentry plugins - #206

Merged
eabruzzese merged 13 commits into
mainfrom
eca-mcp-plugin-wrapper
Oct 6, 2025
Merged

feat: GitHub and Sentry plugins#206
eabruzzese merged 13 commits into
mainfrom
eca-mcp-plugin-wrapper

Conversation

@eabruzzese

@eabruzzese eabruzzese commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR wraps the official MCP servers for Sentry and GitHub as plugins. It also introduces an McpProxyPlugin base class that can be used to easily wrap other MCP servers for future integrations.

See: [SC-34607], [SC-34605], and [SC-34738]

@eabruzzese eabruzzese changed the title Wrap the GitHub and Sentry MCP servers as plugins feat: GitHub and Sentry plugins Oct 2, 2025
@eabruzzese
eabruzzese requested a review from nhient October 2, 2025 19:44
@eabruzzese
eabruzzese marked this pull request as draft October 2, 2025 19:45
@eabruzzese
eabruzzese force-pushed the eca-mcp-plugin-wrapper branch from aa678ee to a5dbaba Compare October 2, 2025 20:00
@eabruzzese
eabruzzese force-pushed the eca-mcp-plugin-wrapper branch from a5dbaba to 44affe6 Compare October 2, 2025 20:09
@eabruzzese
eabruzzese force-pushed the eca-mcp-plugin-wrapper branch from 44affe6 to 0220ee1 Compare October 2, 2025 20:11
@eabruzzese
eabruzzese marked this pull request as ready for review October 2, 2025 20:17
Copilot AI reviewed Oct 2, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

tvdaptible
tvdaptible reviewed Oct 2, 2025
View reviewed changes

@tvdaptible tvdaptible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm overall! A couple validation comments in sentry that also probably apply to GitHub.

For GitHub, do self hosted GitHub enterprise instances have mcp and how would someone configure unpage to use it?

Comment thread src/unpage/plugins/sentry/plugin.py
Comment thread src/unpage/plugins/sentry/plugin.py
nhient
nhient reviewed Oct 2, 2025
View reviewed changes

@nhient nhient left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs look good to me!

tvdaptible
tvdaptible approved these changes Oct 3, 2025
View reviewed changes

@tvdaptible tvdaptible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

i'm supportive of expanding the validation etc in this pr or making that a separate task, so I'm approving the pr for now!

Comment thread src/unpage/plugins/sentry/plugin.py
@eabruzzese
eabruzzese force-pushed the eca-mcp-plugin-wrapper branch from 492af82 to b00c4aa Compare October 3, 2025 20:46
Copilot AI review requested due to automatic review settings October 3, 2025 20:46
Copilot AI reviewed Oct 3, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 4 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/unpage/plugins/sentry/plugin.py Outdated
Comment thread src/unpage/plugins/github/plugin.py
Comment thread src/unpage/plugins/github/plugin.py
Comment thread src/unpage/utils.py Outdated
Copilot AI review requested due to automatic review settings October 3, 2025 20:58
Copilot AI reviewed Oct 3, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 2 comments.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/unpage/plugins/sentry/plugin.py
Comment thread src/unpage/plugins/github/plugin.py
tvdaptible
tvdaptible approved these changes Oct 4, 2025
View reviewed changes

@tvdaptible tvdaptible left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eabruzzese
eabruzzese merged commit 7a8f98c into main Oct 6, 2025
8 checks passed
@eabruzzese
eabruzzese deleted the eca-mcp-plugin-wrapper branch October 6, 2025 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mjp mjp Awaiting requested review from mjp
+2 more reviewers
@nhient nhient nhient left review comments
@tvdaptible tvdaptible tvdaptible approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eabruzzese @nhient @tvdaptible