Repository navigation
Add useSx Fluent styling utilities and useStableCallback - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
useSx, a typed Fluent styling composer for inlineclassNameuse, anduseStableCallback, an alias of Fluent'suseEventCallback. Consumers can compose direct descriptors such assx(width.full, padding.medium, foreground.subtle, typography.body1)with existing Griffel classes.Changes
scrollbar.fluentrecipe, with automatic system colors in forced-colors mode.sideEffects:falseor insertion annotations. Historical API fixtures and transitive lock entries remain unchanged. React 17, TypeScript 5.3.3 and SPFx 1.21.1 are preserved.Validation
npm run verify: 587/587 tests; workspace typechecks/lint and example/runtime/docs/API gates pass.npm run verify:package: all eight isolated consumer commands pass, including actual SPFx ship, strict root/deep compile probes and solution generation; shared Griffel paths/registry and 237 emitted JSDoc declarations verified.npm run bundle:shippass. The verification-only preload keeps the two exact locked browser-data age advisories visible on stdout; other warnings/errors/raw stderr and explicit failure markers remain fatal. Failed unprepared attempts are retained as evidence.Measured impact and limits
Equivalent minimum UI versus direct Griffel: +16,705 gzip bytes via package-root imports, +2,153 via deep imports, and +925 in an app already using FluentProvider and the toolkit. The unchanged/no-useSx consumer still adds 4,486 gzip bytes; 436 upstream token references and 17 typography entries remain. The complete sample adds 31,785 gzip bytes across its reachable asset union; this includes the demo UI and is not the isolated hook cost.
Repeated values reuse classes. The width/body1 probe starts at 150 rules; 1,000 new widths add exactly 1,000 persistent rules/factories, and unmount does not remove them. No live-renderer memory/CSS bound is claimed.
The tested high-contrast inverted preset has 1:1 contrast and is restricted; disabled colors are disabled-only presentation. Browser/platform scrollbar appearance varies. Authenticated SharePoint validation is NOT EXECUTED; local fixtures and package generation do not establish tenant behavior or permissions.