Repository navigation
fix: replay topics with version 1 cursors instead of failing open - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stores written by Craqle 0.2 hold version 1 topic cursors. Version 2 added a branch fence, and every reader rejected a version 1 cursor as expired. Reconciliation runs at open, so any node that ever applied a replicated record failed to open once Irokle sync was configured. The audited cursor repair could not help, because it needs an open node with sync configured.
A verified version 1 cursor now counts as no cursor: the topic replays from the start of its current branch, and the first consumed record stores a fenced version 2 cursor. Replay is safe because a record whose dot the graph clock already covers applies as a duplicate. Corrupt cursors still fail and are never reset.
Changes
legacy_cursor_replays: a replica with a version 1 cursor reconciles, stores a fenced cursor at the same position and exports the same graph.