fix(nextjs): share the initialization between concurrent cold-start requests - #551
Open
DonOmalVindula wants to merge 1 commit into
Open
fix(nextjs): share the initialization between concurrent cold-start requests#551DonOmalVindula wants to merge 1 commit into
DonOmalVindula wants to merge 1 commit into
Conversation
…equests AsgardeoNextClient.initialize() marked the singleton as initialized before its first await, so a second request arriving while the first was still resolving the app origin proceeded with an uninitialized legacy client and failed with "Cannot read properties of undefined (reading 'getConfigData')". A failed initialization also left the client permanently flagged as initialized. Callers now await the initialization in progress, the flag is only set once it succeeds, and a failed attempt is retried by the next call. ensureInitialized() waits for an in-flight initialization instead of throwing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 55 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AsgardeoNextClientis a process-wide singleton, andinitialize()setisInitialized = truebefore its firstawait(getClientOrigin()). On a cold start, requests arriving in parallel (a page request plus RSC prefetches is enough) hit this window:initialize()returned early because the flag was already set,AsgardeoServerProviderthen calledgetConfiguration()while the legacy client had noauthCoreyet, which threwCannot read properties of undefined (reading 'getConfigData')and turned into a 500 for that request.A failed initialization (for example
headers()throwing outside a request scope) had the same shape: the flag stayedtrue, the legacy client stayed uninitialized, and every later call failed until the process restarted.Fix
initialize()keeps the in-flight initialization promise; concurrent callers share it,isInitializedis only set once it succeeds, and a failed attempt is cleared so the next request retries.ensureInitialized()waits for an initialization in progress instead of throwing.Testing
pnpm lint,pnpm vitest run(64 tests) andtsc --noEmitfor@asgardeo/nextjs.Changeset included (
@asgardeo/nextjspatch).🤖 Generated with Claude Code