Repository navigation
fix(cli): correct --version / MCP serverInfo and build the morphkit-mcp bin - #141
Merged
Merged
Conversation
- `morphkit --version` and the banner printed 0.2.3 in the published 0.2.4; the MCP server advertised 0.2.0. Both now 0.2.4. - package.json declares a `morphkit-mcp` bin at dist/mcp/server.js, but `build` and `prepublishOnly` only bundled src/index.ts, so a clean-clone build/publish would ship a missing bin (0.2.4 on npm has it only because it was built by hand). Bundle both entry points with --root src. - test/version.test.ts guards all three so they cannot drift again.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a clean-clone run of the README quickstart.
Bugs:
npx morphkit-cli --versionprints 0.2.3 even though the published package is 0.2.4, and the banner shows the same wrong number. The hard-coded constant insrc/index.tswas never bumped.serverInfo.versionis 0.2.0.package.jsondeclares amorphkit-mcpbin atdist/mcp/server.js, butbuildandprepublishOnlyonly bundlesrc/index.ts. So a cleanbun run buildfollowed bynpm publishships a missing bin. The npm 0.2.4 tarball does have it, so that build was evidently made by hand.Fix:
src/index.tsandsrc/mcp/server.tswith--root srcin both scripts.test/version.test.tsasserts both versions match package.json and that every bin entry is built.Verified locally:
node dist/index.js --versionprints 0.2.4.initializeagainst dist/mcp/server.js returns{name:morphkit, version:0.2.4}.npm pack --dry-runincludes both bins.bun testpass: 260 pass, 7 skip, 0 fail.CI install needs #140 (lockfile) first. I'll update this branch after it merges. Nothing is published here: 0.2.4 on npm still reports 0.2.3, so a 0.2.5 publish is Mason's call.