Skip to content

Skip lines possessively in Forge loading failed pattern - #199

Merged
pavog merged 2 commits into
masterfrom
forge-loading-failed-pattern-backtracking
Nov 16, 2026
Merged

pavog merged 2 commits into
masterfrom
forge-loading-failed-pattern-backtracking

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member

The loading-failed-exception pattern of ModDependencyProblem skipped lines with (?:.*\n)*, which hits the JIT stack limit on entries of about 1 MB, so the missing dependency wasn't reported.

This PR makes the line possessive (.*+), so backtracking happens per line instead of per character.
The outer repetition stays greedy on purpose: a lazy one would report the first instead of the last dependency in the list and change existing results.

Knowingly not covered: only one dependency of the list is reported, that's a separate change.

Changes

  • make the skipped lines possessive in ModDependencyProblem
  • remove it from KNOWN_UNSAFE_PATTERNS

@pavog
pavog merged commit 7d8ead8 into master Nov 16, 2026
3 checks passed
@pavog
pavog deleted the forge-loading-failed-pattern-backtracking branch November 16, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant