Repository navigation
Detect Fabric client logs written by the Modrinth App - #205
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Modrinth App writes the thread and the logger in separate brackets, and the logger name can contain slashes.
Fabric's prefix only allowed one slash before the level, so none of the Fabric detectors matched, and lines with a logger containing a slash didn't start a new entry.
The log was detected as a Vanilla server log because its generic line pattern happens to match most lines, so no Fabric problems were checked.
This PR lets the Fabric prefix and entry pattern accept both forms, and adds a client detector for the Modrinth App's "Setting user" line.
The new alternative requires a thread bracket without a slash, so it can't match the existing
[main/INFO]form, and no existing log intest/datauses it.FabricVersionInformationnow uses the Fabric prefix instead of the Vanilla one, so the loader version is found in this format too.Three existing logs (
fabric-26-1-client-dev,fabric-loom-client,fabric-loom-server) now also report the Fabric Loader version. Their line has no colon after the level ([main/INFO] (FabricLoader/GameProvider) Loading …), which the Vanilla prefix didn't allow.Not covered: Quilt, Forge and NeoForge logs from the Modrinth App, which I haven't seen in this format yet.
Changes
FabricLog::THREAD_PATTERNfor thread and logger in separate bracketsFabricVersionInformationfabric-client-modrinth-app.log