Skip to content

Detect Fabric client logs written by the Modrinth App - #205

Merged
pavog merged 1 commit into
masterfrom
detect-fabric-client-log-from-modrinth-app
Nov 13, 2026
Merged

pavog merged 1 commit into
masterfrom
detect-fabric-client-log-from-modrinth-app

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member
# Minecraft launcher log started at 2026-08-16 09:45:13
[09:45:19] [main] [FabricLoader/GameProvider/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.19.3
[09:45:51] [Render thread] [net.minecraft.class_310/INFO]: Setting user: Player

The Modrinth App writes the thread and the logger in separate brackets, and the logger name can contain slashes.
Fabric's prefix only allowed one slash before the level, so none of the Fabric detectors matched, and lines with a logger containing a slash didn't start a new entry.
The log was detected as a Vanilla server log because its generic line pattern happens to match most lines, so no Fabric problems were checked.

This PR lets the Fabric prefix and entry pattern accept both forms, and adds a client detector for the Modrinth App's "Setting user" line.
The new alternative requires a thread bracket without a slash, so it can't match the existing [main/INFO] form, and no existing log in test/data uses it.
FabricVersionInformation now uses the Fabric prefix instead of the Vanilla one, so the loader version is found in this format too.

Three existing logs (fabric-26-1-client-dev, fabric-loom-client, fabric-loom-server) now also report the Fabric Loader version. Their line has no colon after the level ([main/INFO] (FabricLoader/GameProvider) Loading …), which the Vanilla prefix didn't allow.

Not covered: Quilt, Forge and NeoForge logs from the Modrinth App, which I haven't seen in this format yet.

Changes

  • add FabricLog::THREAD_PATTERN for thread and logger in separate brackets
  • detect Fabric client logs with the Modrinth App's "Setting user" line
  • use the Fabric prefix in FabricVersionInformation
  • add fabric-client-modrinth-app.log

@pavog
pavog merged commit ccc2bb5 into master Nov 13, 2026
3 checks passed
@pavog
pavog deleted the detect-fabric-client-log-from-modrinth-app branch November 13, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant