Repository navigation
Detect Forge and NeoForge client logs written by the Modrinth App - #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Modrinth App writes the thread and the logger in separate brackets, with the level after the logger.
All loaders expected the level in the thread bracket (
[main/INFO]), so Fabric client logs were detected as Vanilla server logs, Forge and NeoForge client logs as server logs, and NeoForge 21.1 as Vanilla.Forge and NeoForge logs were also parsed as a single entry.
This PR lets the entry patterns and the client detectors of Fabric, Forge and NeoForge accept both forms.
The new form needs a thread bracket without a slash, so it can't match the existing
[main/INFO]lines, and no existing log intest/datacontains it.The repeated
[main/INFO]prefix of the Forge and NeoForge detectors is nowForgeLog::MAIN_INFO_PREFIX.FabricVersionInformationnow uses the Fabric prefix instead of the Vanilla one.Three existing Fabric logs (
fabric-26-1-client-dev,fabric-loom-client,fabric-loom-server) now also report the Fabric Loader version, because their line has no colon after the level, which the Vanilla prefix didn't allow.Not covered: Quilt logs from the Modrinth App.
Changes
FabricLog::THREAD_PATTERNandForgeLog::MAIN_INFO_PREFIXFabricVersionInformationfabric-client-modrinth-app.log,forge-client-modrinth-app.log,neoforge-client-modrinth-app.logandneoforge-26-2-client-modrinth-app.log