Skip to content

Detect Forge and NeoForge client logs written by the Modrinth App - #206

Merged
pavog merged 1 commit into
masterfrom
modrinth-app-log-detection
Nov 13, 2026
Merged

pavog merged 1 commit into
masterfrom
modrinth-app-log-detection

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member
# Minecraft launcher log started at 2026-03-19 18:43:17
[18:43:19] [main] [cpw.mods.modlauncher.Launcher/INFO]: ModLauncher running: args [--username, {MINECRAFT_USERNAME}, --version, 1.18.2, ...]
[09:45:19] [main] [FabricLoader/GameProvider/INFO]: Loading Minecraft 1.20.1 with Fabric Loader 0.19.3

The Modrinth App writes the thread and the logger in separate brackets, with the level after the logger.
All loaders expected the level in the thread bracket ([main/INFO]), so Fabric client logs were detected as Vanilla server logs, Forge and NeoForge client logs as server logs, and NeoForge 21.1 as Vanilla.
Forge and NeoForge logs were also parsed as a single entry.

This PR lets the entry patterns and the client detectors of Fabric, Forge and NeoForge accept both forms.
The new form needs a thread bracket without a slash, so it can't match the existing [main/INFO] lines, and no existing log in test/data contains it.
The repeated [main/INFO] prefix of the Forge and NeoForge detectors is now ForgeLog::MAIN_INFO_PREFIX.
FabricVersionInformation now uses the Fabric prefix instead of the Vanilla one.

Three existing Fabric logs (fabric-26-1-client-dev, fabric-loom-client, fabric-loom-server) now also report the Fabric Loader version, because their line has no colon after the level, which the Vanilla prefix didn't allow.

Not covered: Quilt logs from the Modrinth App.

Changes

  • accept thread and logger in separate brackets in the Fabric, Forge and NeoForge entry patterns
  • add FabricLog::THREAD_PATTERN and ForgeLog::MAIN_INFO_PREFIX
  • detect Modrinth App client logs for Fabric, Forge and NeoForge
  • use the Fabric prefix in FabricVersionInformation
  • add fabric-client-modrinth-app.log, forge-client-modrinth-app.log, neoforge-client-modrinth-app.log and neoforge-26-2-client-modrinth-app.log

@pavog
pavog merged commit 6ef93fb into master Nov 13, 2026
3 checks passed
@pavog
pavog deleted the modrinth-app-log-detection branch November 13, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant