Skip to content

Detect Forge client logs from launchers that pass a plain version - #207

Merged
pavog merged 3 commits into
masterfrom
forge-client-log-from-other-launchers
Nov 16, 2026
Merged

pavog merged 3 commits into
masterfrom
forge-client-log-from-other-launchers

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member
[17:55:05] [main/INFO]: ModLauncher running: args [--username, Steve, --version, 26.3, ...
[17:55:07] [main/INFO]: Launching target 'forge_client' with arguments [--version, 26.3, ...

Forge 1.20.2 and newer client logs were only detected when the ModLauncher running line also had a version id containing forge-, as the vanilla launcher and CurseForge pass.
Prism, MultiMC and ATLauncher pass the plain Minecraft version (1.21, 26.3), and some launchers pass a renamed version (Forge 1.21).
Those logs were detected as Forge server, vanilla server, vanilla client or vanilla crash report logs.

This PR detects them by Launching target 'forge_client' alone, because only Forge uses that launch target.

forge-log-crash-report.log was a full Prism client log ending in a crash report and would now be a client log.
It is cut down to the crash report, so it keeps testing crash report detection with a prefix in front of ---- Minecraft Crash Report ----.

Not covered: a client log with a crash report at the end is still detected as a client log for every loader.
That needs its own change.

Changes

  • detect forge_client launch target without checking the version id
  • add forge-26-3-client-atlauncher.log fixture
  • cut forge-log-crash-report.log down to the crash report (only line numbers in the expected output change)

@pavog
pavog merged commit 9bf6504 into master Nov 16, 2026
3 checks passed
@pavog
pavog deleted the forge-client-log-from-other-launchers branch November 16, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant