Repository navigation
Detect Forge client logs from launchers that pass a plain version - #207
Merged
Merged
Conversation
…om-other-launchers # Conflicts: # src/Log/Minecraft/Vanilla/Forge/ForgeClientLog.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forge 1.20.2 and newer client logs were only detected when the
ModLauncher runningline also had a version id containingforge-, as the vanilla launcher and CurseForge pass.Prism, MultiMC and ATLauncher pass the plain Minecraft version (
1.21,26.3), and some launchers pass a renamed version (Forge 1.21).Those logs were detected as Forge server, vanilla server, vanilla client or vanilla crash report logs.
This PR detects them by
Launching target 'forge_client'alone, because only Forge uses that launch target.forge-log-crash-report.logwas a full Prism client log ending in a crash report and would now be a client log.It is cut down to the crash report, so it keeps testing crash report detection with a prefix in front of
---- Minecraft Crash Report ----.Not covered: a client log with a crash report at the end is still detected as a client log for every loader.
That needs its own change.
Changes
forge_clientlaunch target without checking the version idforge-26-3-client-atlauncher.logfixtureforge-log-crash-report.logdown to the crash report (only line numbers in the expected output change)