Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since crash reports are detected before client logs, a Fabric client log that ends in a crash report is analysed by
FabricCrashReportAnalyser.That analyser only knew the ticking entity problems and version information, so mod problems that
FabricAnalyserfinds in client logs were lost, like an entrypoint that threw an exception or a mixin that failed to apply.This PR adds
FabricEntryStageProblemandFabricMixinApplyProblemtoFabricCrashReportAnalyser.The report parser makes one entry per line, and both patterns already fit on a single line, so no crash report variants are needed.
It also detects a crash report as Fabric when the log contains Fabric's "Loading Minecraft X with Fabric Loader Y" line.
This covers a client log that ends in a crash report without its system details, so without a brand line.
Not covered:
FabricMixinProblemandFabricClientOnlyModProblemneed the stack trace below an exception, which spans several entries in a crash report.On a dedicated server crash report, an entrypoint that loaded a client-only class is therefore reported as "has thrown an exception" instead of client-only.
Must be merged after #208.
Changes
FabricEntryStageProblemandFabricMixinApplyProblemtoFabricCrashReportAnalyserfabric-26-2-client.json: the caxton entrypoint problem is backfabric-mixin-apply-error-invalid-descriptor.json: nowfabric/crash-reportinstead ofvanilla/crash-report, problems forrrvandenhanced_storageare back