Skip to content

Report Fabric mod problems in crash reports - #209

Closed
pavog wants to merge 2 commits into
masterfrom
fabric-crash-report-mod-problems
Closed

pavog wants to merge 2 commits into
masterfrom
fabric-crash-report-mod-problems

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member

Since crash reports are detected before client logs, a Fabric client log that ends in a crash report is analysed by FabricCrashReportAnalyser.
That analyser only knew the ticking entity problems and version information, so mod problems that FabricAnalyser finds in client logs were lost, like an entrypoint that threw an exception or a mixin that failed to apply.

This PR adds FabricEntryStageProblem and FabricMixinApplyProblem to FabricCrashReportAnalyser.
The report parser makes one entry per line, and both patterns already fit on a single line, so no crash report variants are needed.

It also detects a crash report as Fabric when the log contains Fabric's "Loading Minecraft X with Fabric Loader Y" line.
This covers a client log that ends in a crash report without its system details, so without a brand line.

Not covered:

  • FabricMixinProblem and FabricClientOnlyModProblem need the stack trace below an exception, which spans several entries in a crash report.
    On a dedicated server crash report, an entrypoint that loaded a client-only class is therefore reported as "has thrown an exception" instead of client-only.
  • The Quilt, Forge and NeoForge crash report analysers still have no mod problems.
  • The cut-down fixture has no information, because the version information for log lines is not part of the crash report analyser.

Must be merged after #208.

Changes

  • add FabricEntryStageProblem and FabricMixinApplyProblem to FabricCrashReportAnalyser
  • detect a crash report as Fabric by the Fabric Loader start line
  • fabric-26-2-client.json: the caxton entrypoint problem is back
  • fabric-mixin-apply-error-invalid-descriptor.json: now fabric/crash-report instead of vanilla/crash-report, problems for rrv and enhanced_storage are back

@pavog pavog closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant