Repository navigation
Detect Arclight crash reports with a loader in the server brand - #210
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arclight crash reports were detected as
vanilla/crash-report.ArclightCrashReportLogwas listed afterVanillaCrashReportLog, which matches every crash report header, and its detector only matched the brand'arclight'.Real Arclight crash reports put the mod loader before the brand and may append the release name, like
'forge arclight'or'neoforge arclight/FeudalKings', so even with a different order none of them matched.This PR widens the server brand pattern and moves
ArclightCrashReportLogright beforeVanillaCrashReportLog.It stays after
NeoForgeCrashReportLogon purpose: NeoForge Arclight crash reports that are already detected as NeoForge keep the NeoForge crash report analyser instead of the generic one Arclight uses.MohistCrashReportLogis not affected, because Mohist writes its own---- Mohist Crash Report ----header that the vanilla detector doesn't match.Not covered: the
Known server brandsline with a loader beforearclight, because I found no complete real report with it.The
fabricprefix is inferred from such a line, not from a realIs Moddedline.Changes
forge,neoforgeandfabricbeforearclightand an optional release name in the arclight crash report detector