Skip to content

Detect Arclight crash reports with a loader in the server brand - #210

Merged
pavog merged 1 commit into
masterfrom
arclight-crash-report-detection
Nov 16, 2026
Merged

pavog merged 1 commit into
masterfrom
arclight-crash-report-detection

Conversation

@pavog

@pavog pavog commented Nov 13, 2026

Copy link
Copy Markdown
Member
---- Minecraft Crash Report ----
...
	Is Modded: Definitely; Server brand changed to 'forge arclight/Executions'

Arclight crash reports were detected as vanilla/crash-report.
ArclightCrashReportLog was listed after VanillaCrashReportLog, which matches every crash report header, and its detector only matched the brand 'arclight'.
Real Arclight crash reports put the mod loader before the brand and may append the release name, like 'forge arclight' or 'neoforge arclight/FeudalKings', so even with a different order none of them matched.

This PR widens the server brand pattern and moves ArclightCrashReportLog right before VanillaCrashReportLog.
It stays after NeoForgeCrashReportLog on purpose: NeoForge Arclight crash reports that are already detected as NeoForge keep the NeoForge crash report analyser instead of the generic one Arclight uses.
MohistCrashReportLog is not affected, because Mohist writes its own ---- Mohist Crash Report ---- header that the vanilla detector doesn't match.

Not covered: the Known server brands line with a loader before arclight, because I found no complete real report with it.
The fabric prefix is inferred from such a line, not from a real Is Modded line.

Changes

  • match forge, neoforge and fabric before arclight and an optional release name in the arclight crash report detector
  • detect arclight crash reports before vanilla crash reports
  • add arclight-crash-report.log and arclight-crash-report-with-release-name.log

@pavog
pavog merged commit 69e059c into master Nov 16, 2026
3 checks passed
@pavog
pavog deleted the arclight-crash-report-detection branch November 16, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant