Repository navigation
Support js-sources for the mhs backend - #40
Merged
Merged
Conversation
The js-sources of a library are installed in the jsbits directory of the package, and for executables they are passed to mhs with -js. mhs embeds them in the output for targets that support it (e.g., the emscripten targets, with --pre-js). This needs the -js flag and jsbits support in mhs, from augustss/MicroHs#529. Packages without js-sources are not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
js-sourcessupport to the mhs backend, matching GHC's JavaScript backend. miso needs it to embedmiso.jswhen built withmcabal.This depends on augustss/MicroHs#529, which adds the
-jsflag andjsbitssupport tomhs. Without it, an executable withjs-sourcesfails with mhs's "Unknown flag" error. Packages withoutjs-sourcesare not affected.Changes
js-sourcesof a library are installed in thejsbitsdirectory of the package.mhsembeds the.jsfiles there when linking a program that uses the package.js-sourcesare passed tomhswith-js.mhsembeds the files for targets that support it, such asemscripten, with--pre-js. Other targets ignore them.Testing
With the
mhsfrom augustss/MicroHs#529, I installed a small package that declaresjs-sourceswith thismcabal. Its JavaScript file was installed injsbits. A program using the package, built foremscripten, embedded the file and called a function from it throughforeign import javascript.