Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
verify()comparednbfagainstclockTimestamp, which is the current time truncated to whole seconds. Whennbfis fractional, a token that is already active can be rejected withjwt not active. For example, withnbf = 1646822341.111andDate.now() = 1646822341999, the truncated time is1646822341, sonbf > clockTimestamp.This change compares
nbfagainst the exact current time (Date.now() / 1000).expandmaxAgekeep using the truncated time, so their behavior does not change. Whenoptions.clockTimestampis provided, it is still used as is.References
Fixes #817
Testing
nbfthat is already active within the current second is accepted.nbfthat is still in the future within the same second is rejected.npm testpasses.