Repository navigation
Return empty digest when failing verification - #626
Merged
Merged
Conversation
samliok
approved these changes
Oct 14, 2026
|
|
||
| // block1 was finalized by the rest of the network, which is what allowed block0 to be finalized | ||
| // despite round 0 being empty notarized. We ensure that finalizing block1 through replication commits it. | ||
| finalization1, _ := testutil.NewFinalizationRecord(t, sigAggr, block1, nodes[0:3]) |
Collaborator
There was a problem hiding this comment.
why is this last check necessary for the test?
Collaborator
Author
There was a problem hiding this comment.
Because otherwise the scenario doesn't make sense, because the only reason we finalized block0 is because we finalized block1 above it.
Collaborator
Author
There was a problem hiding this comment.
I don't want us or anyone else in the future think we didn't know that
yacovm
force-pushed
the
schedTaskDespiteEmptyNot
branch
from
October 14, 2026 17:15
c1c2531 to
c41ceb4
Compare
When we verify a block, the task returns the ID of the block. But a block's verification may fail. In case it fails, we shouldn't schedule the next block, as the previous one should successfully verify first. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
yacovm
force-pushed
the
schedTaskDespiteEmptyNot
branch
from
October 14, 2026 17:47
c41ceb4 to
066aaef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we verify a block, the task returns the ID of the block.
But a block's verification may fail. In case it fails, we shouldn't schedule the next block, as the previous one should successfully verify first.
Also fixes a corner case where we replicate a finalization but don't schedule the dependent tasks.