Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion wal/record.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,25 @@ import (
"fmt"
"hash/crc64"
"io"
"math"
)

const (
recordSizeLen = 4
recordChecksumLen = 8
)

var ErrInvalidCRC = errors.New("invalid CRC checksum")
var (
ErrInvalidCRC = errors.New("invalid CRC checksum")
ErrPayloadTooLarge = errors.New("payload too large for record length field")
)

// writeRecord writes a length-prefixed and check-summed record to the writer.
func writeRecord(w io.Writer, payload []byte) error {
if uint64(len(payload)) > math.MaxUint32 {
return fmt.Errorf("%w: %d bytes", ErrPayloadTooLarge, len(payload))
}

checksumIndex := recordSizeLen + len(payload)
buff := make([]byte, checksumIndex+recordChecksumLen)
crc := crc64.New(crc64.MakeTable(crc64.ECMA))
Expand Down
10 changes: 10 additions & 0 deletions wal/record_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ func TestWriteRecord(t *testing.T) {
)
}

// TestWriteRecordRejectsOversizedPayload ensures a payload whose length does not fit in the
// 32 bit length field is rejected before anything is written.
func TestWriteRecordRejectsOversizedPayload(t *testing.T) {
payload := make([]byte, math.MaxUint32+1)

var buff bytes.Buffer
require.ErrorIs(t, writeRecord(&buff, payload), ErrPayloadTooLarge)
require.Zero(t, buff.Len())
}

func TestReadRecord(t *testing.T) {
require := require.New(t)

Expand Down
Loading