Repository navigation
wal review? - #629
Open
samliok wants to merge 3 commits into
Open
wal review?#629samliok wants to merge 3 commits into
samliok wants to merge 3 commits into
Conversation
yacovm
reviewed
Oct 18, 2026
| require.NoError(t, e.Start()) | ||
|
|
||
| md := e.Metadata() | ||
| require.Equal(t, uint64(5), md.Epoch) |
Collaborator
There was a problem hiding this comment.
This test doesn't test that we haven't loaded the stale block into the memory. It just tests that if we propose a block, we will propose it with the right epoch.
Collaborator
|
I think it's much more easier to review a new PR that adds the garbage collected WAL instead of fixing the existing code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I really think adding the epoch aware wal in the way we do makes things too complex. Its an additional 250 lines of code plus we need to wrap the WAL when we initialize the epoch. We also need to update the instance code just to support this new wal too.
This PR has two commits
The first removes the epoch wal and has very simple logic to read the correct records from the wal.
The second commit removes the logic from the epoch into its own testable function, that IMO is just as testable as EpochAwareWal but has a smaller surface area for bugs.
The third commit is some more simplifications we can do