Repository navigation
Conversation
|
Hi @phipag I have tested the changes in my own AWS account, below you can find the code and logs that i have used to test this changes package com.davinchicoder;
import com.amazonaws.services.lambda.runtime.Context;
import com.amazonaws.services.lambda.runtime.RequestHandler;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import software.amazon.lambda.powertools.logging.PowertoolsLogging;
import java.util.Map;
/**
* Lambda function entry point. You can change to use other pojo type or implement
* a different RequestHandler.
*
* @see <a href=https://docs.aws.amazon.com/lambda/latest/dg/java-handler.html>Lambda Java Handler</a> for more information
*/
public class App implements RequestHandler<Map<String, String>, String> {
private static final Logger log = LoggerFactory.getLogger(App.class);
static {
log.info("Static initializer");
PowertoolsLogging.init();
}
public App() {
log.info("Constructor");
}
@Override
public String handleRequest(Map<String, String> input, Context context) {
return PowertoolsLogging.withLogging(context, () -> {
log.info("Handling request");
return "OK";
});
}
} |
|
|
@phipag Could you please review this PR? |
phipag
left a comment
There was a problem hiding this comment.
Thanks for adding SnapStart priming to the logging module, @David-DAM. The CRaC registration follows the same pattern as tracing and large messages. I left two comments to address before we merge.
|
phipag
left a comment
There was a problem hiding this comment.
Thanks @David-DAM for your contribution, again!
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |



Issue number: Closes #2001
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.