Repository navigation
fix(data-classes): handle keyword arguments in CaseInsensitiveDict.update - #8518
Merged
leandrodamascena merged 1 commit intoOct 6, 2026
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8518 +/- ##
========================================
Coverage 96.92% 96.92%
========================================
Files 317 317
Lines 15911 15911
Branches 1398 1398
========================================
Hits 15422 15422
Misses 353 353
Partials 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leandrodamascena
approved these changes
Oct 6, 2026
leandrodamascena
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this, @chiruu12! Glad you caught the two-character case too, since that was silently storing the wrong value. I tried a few extra cases with your fix and they all passed. Looks good to me!
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
leandrodamascena
merged commit Oct 6, 2026
3e4d498
into
aws-powertools:develop
20 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8517
Summary
Changes
CaseInsensitiveDict.updatelooped overkwargsitself, so it got key strings rather than(key, value)pairs. It now iterateskwargs.items().Added
tests/unit/data_classes/required_dependencies/test_common.pycovering keyword arguments in both the constructor andupdate(). Both tests fail ondevelopand pass with the change.User experience
Before,
CaseInsensitiveDict(ab=1)produced{'a': 'b'}and any keyword name that is not exactly two characters long raisedValueError, includingevent.headers.update(User_Agent="test").After, keyword arguments are stored as lowercased keys with their values, same as a mapping passed positionally.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.