perf(parser): load event models on demand - #8519
Open
leandrodamascena wants to merge 1 commit into
Open
leandrodamascena wants to merge 1 commit into
leandrodamascena wants to merge 1 commit into
Conversation
|
1 of 2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8519 +/- ##
===========================================
- Coverage 96.92% 96.92% -0.01%
===========================================
Files 317 317
Lines 15911 15899 -12
Branches 1398 1400 +2
===========================================
- Hits 15422 15410 -12
Misses 353 353
Partials 136 136 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #8515
Summary
Changes
Importing a single parser model currently loads all 27 model modules and builds schemas for unrelated event types. Resolve model exports and submodule attributes on first access, then cache the original objects.
Retains the existing
__all__, imports for static type checking, and attribute discovery throughdir(). Adds tests in fresh Python processes for import paths, model dependencies, public exports, class identity, serialization, and concurrent access.User experience
Existing imports such as
from aws_lambda_powertools.utilities.parser.models import SqsModelkeep their syntax and validation behavior while loading only the requested module and its dependencies.Measured before and after this change:
SqsModelfromparser.modelsPartialItemFailureResponsewith Pydantic already loadedEach case ran in 20 fresh interpreters in the official Lambda Python 3.13 ARM64 image, with 512 MiB and 0.29 CPU. Both source copies were precompiled and used the same dependencies. Pydantic and an application model were initialized before timing. These are Docker import measurements, not deployed Lambda cold-start measurements; timings vary under CPU throttling.
Compatibility
Direct namespace inspection now sees only resolved exports. Code that reads an unloaded model from
vars(models)ormodels.__dict__, or supplies that dictionary to Pydantic for forward-reference resolution, can fail until the model is imported.inspect.getmembers_static()is also affected. Explicit imports andgetattr(models, name)resolve the model normally.This PR addresses the parser model initializer. The separate Batch, data class, and Tracer changes in #8515 remain follow-up work.
Validation
parser.models: 100% line and branch coverage on Python 3.14.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.