Repository navigation
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/M
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #8536
Summary
Changes
CaseInsensitiveDictnow overridescopy,__or__,__ror__and__ior__.copy,|and the reflected|return aCaseInsensitiveDict, and all of them go through the existingupdate, so new keys are lowercased the same way as everywhere else.Two tests added to
tests/unit/data_classes/required_dependencies/test_common.py. Both fail ondevelopand pass with the change.User experience
Before,
event.headers.copy().get("Content-Type")returnedNone,headers | {...}gave back a plaindict, andheaders |= {"X-Trace-Id": "1"}storedX-Trace-Idwithout lowercasing it.After, a copy or merge of
event.headerskeeps case-insensitive lookup.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.