[Thanatos9404]

Issue number: closes #8575

Summary

Changes

_item_to_data_record read the expiry with item.get("expiration"), while _put_in_progress_record and _update_record write it under self.expiry_attr. With a custom expiry_attr, every record came back with expiry_timestamp=None. It now reads self.expiry_attr, like the other attributes.

I checked the other attribute names in the same method: in_progress_expiry_attr, status_attr, data_attr and validation_key_attr already use the configured names. "expiration" was the only hardcoded one.

Tests (added to tests/functional/idempotency/_redis/test_redis_layer.py, each run with the default expiration and a custom exp):

• test_get_record_reads_expiry_from_expiry_attr: the snippet from the issue. A COMPLETED record stored with an expiry of 1 reads back with expiry_timestamp == 1, is_expired true and the matching get_expiration_datetime().
• test_idempotent_function_redis_expiry_attr_round_trip: through @idempotent_function with a response_hook:
  • the first call stores the record with the expiry under the configured name (and no other expiry key);
  • the second call returns the stored response, and the hook gets the stored expiration instead of None;
  • once the stored expiry is in the past while the key is still in the cache, the function runs again instead of returning the old response.

The two exp cases fail on develop (expiry_timestamp is None, and the hook gets [None]); the expiration cases pass on both. All 4 pass with this change.

Checks

• tests/functional/idempotency and tests/unit/idempotency: 198 passed.
• ruff check and ruff format --check on the changed files: clean.
• mypy on redis.py: clean. ty check on redis.py shows the same 8 deprecation warnings as develop (the deprecated Redis* names) and nothing new.

User experience

Before:

layer = CachePersistenceLayer(client=my_redis_client, expiry_attr="exp")
my_redis_client.set("k", '{"status": "COMPLETED", "exp": 1, "data": "{}"}')

record = layer._get_record("k")
print(record.expiry_timestamp, record.is_expired)  # None False

After: 1 True.

What this changes for users with a custom expiry_attr:

• data_record.get_expiration_datetime() in a response_hook returns the expiration instead of None.
• A record that has passed its expiry but is still in the cache is treated as expired, so the function runs again instead of returning the old response.
• With use_local_cache=True, a record read from the cache (one written by another execution environment) is stored in the local cache with its expiry. Before, it had no expiry, so the local copy never expired and was served until it was evicted.

With the default expiry_attr, nothing changes.

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

[leandrodamascena]

Thanks @Thanatos9404, two for two! I ran the suite and compared develop and your branch side by side with a custom expiry_attr: on develop an expired record that is still in Redis gets replayed forever, with your fix it re-runs like DynamoDB does, and the response hook finally sees the real expiration. Default expiration behaves exactly as before.

Approving now, this one also goes out in 3.38.0, so it will wait here a bit before I merge. No need to rebase or touch anything, I'll handle it and you'll get the credit in the release notes. Thank you!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.93%. Comparing base (ab83696) to head (ac156f6).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #8606   +/-   ##
========================================
  Coverage    96.93%   96.93%           
========================================
  Files          318      318           
  Lines        16067    16067           
  Branches      1430     1430           
========================================
  Hits         15575    15575           
  Misses         349      349           
  Partials       143      143           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud