Skip to content

fix(parameters): make GetSecretError a subclass of GetParameterError #8612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tanmay-Ts wants to merge 1 commit into from
Closed

fix(parameters): make GetSecretError a subclass of GetParameterError #8612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/parameters/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from .appconfig_extension import AppConfigExtensionProvider
from .base import BaseProvider, clear_caches
from .dynamodb import DynamoDBProvider
from .exceptions import GetParameterError, TransformParameterError
from .exceptions import GetParameterError, GetSecretError, TransformParameterError
from .secrets import SecretsProvider, get_secret, get_secrets_by_name, set_secret
from .ssm import SSMProvider, get_parameter, get_parameters, get_parameters_by_name, set_parameter

Expand All @@ -15,6 +15,7 @@
"AppConfigProvider",
"BaseProvider",
"GetParameterError",
"GetSecretError",
"DynamoDBProvider",
"SecretsProvider",
"SSMProvider",
Expand Down
2 changes: 1 addition & 1 deletion aws_lambda_powertools/utilities/parameters/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class GetParameterError(Exception):
"""When a provider raises an exception on parameter retrieval"""


class GetSecretError(Exception):
class GetSecretError(GetParameterError):
"""When a provider raises an exception on secret retrieval"""


Expand Down
12 changes: 12 additions & 0 deletions tests/functional/parameters/_boto3/test_utilities_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3533,3 +3533,15 @@ def test_secrets_provider_get_multiple_with_json_transform_error(config):

with pytest.raises(parameters.TransformParameterError):
provider.get_multiple(secret_names, transform="binary", raise_on_transform_error=True)


def test_get_secret_error_is_caught_as_get_parameter_error(config):
# GIVEN a SecretsProvider instance
provider = parameters.SecretsProvider(boto_config=config)

# WHEN get_multiple raises GetSecretError
# THEN it can be caught as GetParameterError, as the docstrings say
with pytest.raises(parameters.GetParameterError):
provider.get_multiple([])

assert parameters.GetSecretError is GetSecretError