Repository navigation
fix(parameters): make GetSecretError inherit from GetParameterError - #8613
Closed
benzanmontage-hue wants to merge 1 commit into
Closed
benzanmontage-hue wants to merge 1 commit into
benzanmontage-hue wants to merge 1 commit into
Conversation
|
No acknowledgement section found. Please make sure you used the template to open a PR and didn't remove the acknowledgment section. Check the template at |
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
GetSecretErrorsubclassesExceptiondirectly, but the docstrings ofget_secrets_by_nameandSecretsProvider.get_multipledocument that theyraise
GetParameterError. As a result, anexcept GetParameterErroraround abatch secret call silently misses the failure.
Changes
GetSecretErrorinherit fromGetParameterErrorinexceptions.py.GetSecretErrorfromaws_lambda_powertools.utilities.parameters.Verification
Fixes #8595