Repository navigation
fix(invoke): allow bearer tokens for harness IDs - #2753
Merged
Merged
Conversation
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-2753-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-1.0.1.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
nborges-aws
requested changes
Nov 4, 2026
nborges-aws
left a comment
nborges-aws
left a comment
Contributor
There was a problem hiding this comment.
one finding otherwise LGTM
| const HTTP_BEARER_AUTH_SCHEME = "smithy.api#httpBearerAuth"; | ||
|
|
||
| export const createDataClient: CreateDataClient = ({ bearerToken, ...config }) => { | ||
| if ( |
Contributor
There was a problem hiding this comment.
Can we enforce HTTPS on the request endpoint before sending? The check we have now only covers config.endpoint. If the endpoint is resolved through AWS config or any other means, it could send the token over plaintext
jariy17
changed the title
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jariy17
commented
Nov 4, 2026
| import { InvokeHarnessCommand } from "@aws-sdk/client-bedrock-agentcore"; | ||
| import { createDataClient } from "./factories"; | ||
|
|
||
| test("createDataClient signs bearer invocations without resolving AWS credentials", async () => { |
Contributor
Author
There was a problem hiding this comment.
remove this for now.
jariy17
commented
Nov 4, 2026
| expect(pending).rejects.toMatchObject({ name: "AbortError" }); | ||
| }); | ||
|
|
||
| test("invokeHarness uses an uncached bearer client and destroys it after streaming", async () => { |
jariy17
force-pushed
the
fix/harness-bearer-token-direct-invoke
branch
from
November 4, 2026 20:53
4e3c18f to
54bab64
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jariy17
commented
Nov 4, 2026
| @@ -0,0 +1,64 @@ | |||
| import { expect, spyOn, test } from "bun:test"; | |||
Contributor
Author
There was a problem hiding this comment.
no core tests please. This should covered by golden tests.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
nborges-aws
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow one-shot CUSTOM_JWT Harness invocation with
--bearer-tokenonagentcore invoke --harnessandagentcore harness invoke --id.Like Runtime invoke, Harness invoke first calls
GetHarnessusing AWS credentials and validates the configured authorizer. The data-plane request uses a Harness-only Smithy bearer client rather than SigV4. The sharedcreateDataClientfactory is unchanged. Harness IDs are required byharness invoke;agentcore invokecan select a Harness by ARN but still resolves it throughGetHarness. This change does not enable invocation without AWS credentials.Tokens can be inline, read from stdin (
-), or read fromfile://. Empty and multiline tokens are rejected. IAM Harnesses reject bearer tokens, and CUSTOM_JWT Harnesses require them. The bearer client enforces HTTPS and is destroyed after the response stream is consumed.Related Issue
Related to #2741, but does not close it: the credential-free full-ARN use case remains unsupported.
Documentation PR
Documentation is included in this PR.
Type of Change
Testing
bun test: 4,719 passed, 6 Windows-only skips on Linuxbun run typecheckbun run lint:checkbun run format:checkbun run buildbun run secrets:checkbun run audit: configured CodeArtifact advisory endpoint returned HTTP 404Checklist
command.mdBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution to your work, under the terms of your choice.