chore: stop building a RegExp from a raw filesystem path - #1964
Merged
aws-cdk-automation merged 1 commit intoSep 22, 2026
Merged
Conversation
…m path On Windows the separator is a backslash, so interpolating the joined temp path into a RegExp turned sequences such as backslash-U and backslash-T into identity escapes and silently dropped the separators. The pattern then matched nothing and the test failed on every Windows checkout. Compare the prefix as a plain string instead.
mrgrain
approved these changes
Sep 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 79 79
Lines 12217 12217
Branches 1724 1724
=======================================
Hits 11157 11157
Misses 1025 1025
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One test in
@aws-cdk/cloud-assembly-apibuilds a RegExp out of a joined temp path. On Windows the separator is a backslash, so the\U,\A,\Land\Tin a path likeC:\Users\...\AppData\Local\Tempare read as identity escapes and those backslashes are silently dropped. The pattern then matches nothing and the test fails on every Windows checkout, while jest still prints the intact-looking path, so the cause is not obvious from the output.Raising it now because of #1772 and the opt-in Windows integ-test label added in #1957. Comparing the prefix as a plain string removes the class of bug rather than escaping around it.
Running this package's jest on Windows goes from 2 failed, 84 passed to 1 failed, 85 passed. The remaining failure,
assembly with tree metadata having no file property specified, is there before and after and is unrelated to this change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license