Skip to content

test: add replay identity conformance case - #701

Merged
zhongkechen merged 1 commit into
mainfrom
test/conformance-general-11-1
Sep 8, 2026
Merged

test: add replay identity conformance case#701
zhongkechen merged 1 commit into
mainfrom
test/conformance-general-11-1

Conversation

@zhongkechen

Copy link
Copy Markdown
Contributor

Summary

  • add the general conformance suite and handler for requirement 11-1
  • emit a named WAIT on the first invocation and a named STEP at the same replay position
  • enable replay-visible canary logging and prove the mismatched step body never executes
  • make replay-identity diagnostics identify checkpointed values as expected and emitted values as current

Dependencies

Testing

  • python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/discover_suites.py
  • python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/build_examples.py
  • focused state tests: 4 passed
  • focused execution tests: 3 passed
  • hatch run dev-core:typecheck
  • Ruff check and format verification for changed Python files
  • git diff --check

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 21:27 — with GitHub Actions Inactive
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 1, 2026 21:43 — with GitHub Actions Inactive
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.


@durable_step
def unexpected_step(step_context: StepContext) -> str:
step_context.logger.info("DETERMINISM_STEP_BODY_EXECUTED")

This comment was marked as outdated.

@github-actions

This comment has been minimized.

Base automatically changed from fix/replay-operation-identity to main September 3, 2026 21:26
ayushiahjolia
ayushiahjolia previously approved these changes Sep 8, 2026
@zhongkechen
zhongkechen force-pushed the test/conformance-general-11-1 branch from ce7528d to cd186ca Compare September 8, 2026 21:21
@zhongkechen
zhongkechen temporarily deployed to ai-pr-review-runtime September 8, 2026 21:36 — with GitHub Actions Inactive
from aws_durable_execution_sdk_python.execution import durable_execution


@durable_step

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex AI review · Finding arf_v1_qk6nurjxyn6fmk3nrrncxxiaaq

[P2] Make the step-body canary replay-visible

This step inherits the durable context's replay-aware logger, so this INFO record is suppressed while replaying. If a regression executes unexpected_step before rejecting the identity mismatch, the canary remains absent and requirement 11-1 cannot detect the forbidden execution. Cast step_context.logger to the concrete Logger and emit through with_is_replaying(lambda: False) so the execution metadata is preserved while the canary remains visible.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Codex AI review

One conformance-test reliability issue remains: the forbidden step-body canary can be suppressed during replay, weakening requirement 11-1.

Reviewed commit cd186ca793a12ec9d5fe7f95c1aae1d321b31691. Workflow run

@zhongkechen
zhongkechen merged commit d61985e into main Sep 8, 2026
66 of 74 checks passed
@zhongkechen
zhongkechen deleted the test/conformance-general-11-1 branch September 8, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants