test: add replay identity conformance case - #701
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| @durable_step | ||
| def unexpected_step(step_context: StepContext) -> str: | ||
| step_context.logger.info("DETERMINISM_STEP_BODY_EXECUTED") |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
ce7528d to
cd186ca
Compare
| from aws_durable_execution_sdk_python.execution import durable_execution | ||
|
|
||
|
|
||
| @durable_step |
There was a problem hiding this comment.
Codex AI review · Finding arf_v1_qk6nurjxyn6fmk3nrrncxxiaaq
[P2] Make the step-body canary replay-visible
This step inherits the durable context's replay-aware logger, so this INFO record is suppressed while replaying. If a regression executes unexpected_step before rejecting the identity mismatch, the canary remains absent and requirement 11-1 cannot detect the forbidden execution. Cast step_context.logger to the concrete Logger and emit through with_is_replaying(lambda: False) so the execution metadata is preserved while the canary remains visible.
Codex AI reviewOne conformance-test reliability issue remains: the forbidden step-body canary can be suppressed during replay, weakening requirement 11-1. Reviewed commit |
Summary
generalconformance suite and handler for requirement11-1WAITon the first invocation and a namedSTEPat the same replay positionDependencies
Testing
python3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/discover_suites.pypython3 packages/aws-durable-execution-sdk-python-conformance-tests/scripts/build_examples.pyhatch run dev-core:typecheckgit diff --checkBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.