fix: complete emulator REST APIGatewayProxyRequest and null-safe AspNetCoreServer marshalling - #2567
Open
msmourao wants to merge 1 commit into
Open
Conversation
…er marshalling API Gateway emulator REST translation omitted RequestContext and could leave Path/HttpMethod null, causing NullReferenceException in Amazon.Lambda.AspNetCoreServer. Fixes aws#2566 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #2566
Description of changes:
When the Lambda Test Tool v2 API Gateway emulator translates an HTTP request into a REST
APIGatewayProxyRequest, it omittedRequestContextand could leavePath/HttpMethodnull.Amazon.Lambda.AspNetCoreServerthen threwNullReferenceExceptionwhile marshalling those incomplete events into ASP.NET Core features.This PR:
RequestContext(and default Path/HttpMethod) for emulator-built REST proxy events, closer to real API Gateway / test-invoke payloads. HTTP API v2 translation already setRequestContext.Path,HttpMethod, path parameters, and header values so incomplete events do not NRE.Includes an AutoVer change file (Patch) for both projects.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.