JSON number parsing bug fix - #3921
Open
pulimsr wants to merge 3 commits into
Open
Conversation
pulimsr
force-pushed
the
fix-json-number-parsing
branch
from
September 8, 2026 18:54
bbf9531 to
bbe7024
Compare
pulimsr
force-pushed
the
fix-json-number-parsing
branch
from
September 8, 2026 20:27
bbe7024 to
e937d92
Compare
sbiscigl
reviewed
Sep 9, 2026
|
|
||
| namespace | ||
| { | ||
| const double LLONG_MIN_AS_DOUBLE = -9223372036854775808.0; |
Collaborator
There was a problem hiding this comment.
lets no use actual hard coded numbers, those are fragile, use numeric limits where you can
constexpr double LLONG_MIN_AS_DOUBLE =
static_cast<double>(std::numeric_limits<int64_t>::min());
constexpr double LLONG_MAX_PLUS_ONE =
-static_cast<double>(std::numeric_limits<int64_t>::min());|
|
||
| namespace | ||
| { | ||
| const double LLONG_MIN_AS_DOUBLE = -9223372036854775808.0; |
Collaborator
There was a problem hiding this comment.
same about using numerical limits
| const double LLONG_MIN_AS_DOUBLE = -9223372036854775808.0; | ||
| const double LLONG_MAX_PLUS_ONE = 9223372036854775808.0; | ||
|
|
||
| bool IsRepresentableAsInt64(double value) |
Collaborator
There was a problem hiding this comment.
these functions appear copy and pasted twice lets move them into a header that is not installed/part of the public API. somewhere in aws/core/utils, maybe under a new directory that is build alongside the SDK but not installed. numeric utils or something of the like
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix JSON number parsing edge cases in aws-cpp-sdk-core
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.