Conversation
…onverter The readability note incorrectly linked ZoneOffsetAttributeConverter, which only converts ZoneOffset values like "+01:00". Sibling converters (OffsetDateTimeAsStringAttributeConverter) correctly reference ZonedDateTimeAsStringAttributeConverter for values without a named zone.
tanvir-ux
force-pushed
the
fix-instant-as-string-javadoc-zoned-link
branch
from
September 15, 2026 01:11
fe440b2 to
bfec2e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
InstantAsStringAttributeConverterjavadoc says it can read values "with zero offset and without time zone named" written byZoneOffsetAttributeConverter.That link is wrong:
ZoneOffsetAttributeConverterconvertsZoneOffsetstrings such as+01:00, not zoned date-times. The siblingOffsetDateTimeAsStringAttributeConverterdocs correctly point atZonedDateTimeAsStringAttributeConverterfor the same "without a time zone named" case.Modifications
Update the
{@link ...}toZonedDateTimeAsStringAttributeConverter.Testing
Docs-only change; verified against
OffsetDateTimeAsStringAttributeConverterjavadoc wording and theZoneOffsetAttributeConverter/ZonedDateTimeAsStringAttributeConverterclass purposes.Types of changes
Checklist