Repository navigation
Warn that the ECS guide deploys publicly and require a source range - #2375
Merged
Merged
Conversation
kmcginnes
force-pushed
the
ecs-guide-restrict-security-group
branch
from
October 7, 2026 22:26
d2c3ac1 to
7c03f1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ECS guide's own
[!IMPORTANT]says never to make Graph Explorer publicly reachable without an access control layer, but the steps then built exactly that: the security group rule only said "Preferably" restrict the source, so a reader who followed it literally got an internet-facing deployment with no authentication./explorer/health check passes but every query times out.{YOUR_CIDR}. If the reader has to correct it, the step says to force a new deployment, since the first one stops retrying once its health checks fail.resolveServerConfigpicks, and withPROXY_SERVER_HTTPS_CONNECTION=truein the task definition that port is 443.This is the small slice of #2225. Splitting the load balancer and task groups, private subnets, the IAM role split, and the
/statushealth check stay on that issue.Evidence
Before: the 443 rule's source was left to the reader with only a "Preferably", a port 80 rule opened a port nothing binds, and nothing allowed the tasks to reach Neptune.
After: every rule names its source and says why it's there, and the reader confirms the load balancer's group.
No live AWS run. The console steps were checked against the ECS, Elastic Load Balancing, and VPC documentation.
Merge Danger
Door: two-way
Docs only. No code or image changes.
Impact: guidance
A reader following the guide now creates the security group in the EC2 console and needs their public CIDR to hand. Existing deployments are unaffected. Anyone who followed the old steps should check that their security group's inbound source is limited to their own address range.
Related