Skip to content

Lint the Vite config files - #2412

Merged
kmcginnes merged 1 commit into
mainfrom
lint-config-files
Oct 14, 2026
Merged

kmcginnes merged 1 commit into
mainfrom
lint-config-files

Conversation

@kmcginnes

Copy link
Copy Markdown
Collaborator

Summary

The lint config ignored every *.config.{js,ts,mjs} file, so vite-plus/prefer-vite-plus-imports never saw the four vite.config.ts files, which is where a stray vite or vitest import is most likely to come back.

-    ignorePatterns: ["**/*.config.{js,ts,mjs}", ".claude/"],
+    ignorePatterns: [".claude/"],

The configs already pass every rule, including the type-aware ones, so nothing else changes.

Evidence

Before: changing packages/shared/vite.config.ts to import from "vite" passed vp lint.
After: the same change fails:

packages/shared/vite.config.ts:1:30: error vite-plus(prefer-vite-plus-imports): Use 'vite-plus' instead of 'vite' in Vite+ projects.

Merge Danger

Door: two-way

Impact: contributors

Lint now covers 4 more files. No runtime or build change.

Related

@kmcginnes kmcginnes left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kmcginnes
kmcginnes merged commit 3bc6a6c into main Oct 14, 2026
4 checks passed
@kmcginnes
kmcginnes deleted the lint-config-files branch October 14, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant