Skip to content

Run vp check inside pnpm checks - #2414

Merged
kmcginnes merged 1 commit into
mainfrom
vp-check-in-checks
Oct 14, 2026
Merged

kmcginnes merged 1 commit into
mainfrom
vp-check-in-checks

Conversation

@kmcginnes

Copy link
Copy Markdown
Collaborator

Summary

pnpm checks ran lint and format as two separate scripts. vp check runs both in one pass, so checks now calls it and keeps the tsc type check after it.

-    "checks": "pnpm run check:lint && pnpm run check:format && pnpm run check:types",
+    "checks": "vp check && pnpm run check:types",

check:lint, check:format, and check:types stay for running one check on its own. CI still calls pnpm checks.

Evidence

Each failure planted in packages/shared/src/constants.ts still fails pnpm checks:

  • Lint (debugger;): exit 1, error: Lint issues found
  • Format (export const x = 1): exit 1, error: Formatting issues found
  • Types (const y: number = "s"): exit 1, TS2322: Type 'string' is not assignable to type 'number'
  • Clean tree: exit 0

Merge Danger

Door: two-way

Impact: contributors

Only the shape of the pnpm checks output changes.

Related

@kmcginnes kmcginnes left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@kmcginnes
kmcginnes merged commit 235c749 into main Oct 14, 2026
5 checks passed
@kmcginnes
kmcginnes deleted the vp-check-in-checks branch October 14, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant