Repository navigation
Set up CI with Vite+ - #2417
Merged
Merged
Set up CI with Vite+#2417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI set up Node, pnpm, and the install as three separate steps.
voidzero-dev/setup-vpdoes all three from the files the repo already pins, so CI follows the same Vite+ toolchain contributors run locally.With no version inputs, setup-vp resolves:
vite-pluscatalog entry (1.1.0).node-versionpackageManager, including its+sha512hashThe new build step catches a broken
vite buildbefore the Docker workflow does.docs/development.mddrops thepnpm/action-setupupgrade notes and now says Vite+ checks the pnpm hash as well.Evidence
Before: setup-node and pnpm/action-setup installed the toolchain, and CI never ran
pnpm build.After: run 38640754820 passed every step. Its log shows
Resolved Vite+ version '1.1.0' from package.json, Nodev24.21.0, andDone in 13s using pnpm v12.8.1. It also saved the dependency cache.I ran two more checks:
run-installleft at its default failed withERR_PNPM_OUTDATED_LOCKFILE. The explicit--frozen-lockfilestays anyway, so the guarantee doesn't depend on that default.packageManagerhash,vp installstops withHash mismatch for pnpm@12.8.1.The job took 5m 0s on a cold cache, against 3m 52s for the last
mainrun. Install took 20s, and the new build step took 10s.Merge Danger
Door: two-way
Impact: CI
The dependency cache key changes once. Dependabot's existing
actionsgroup will bump setup-vp.Related