Skip to content

ci(ci): Add a candidate clock to the Strength workflow for time odds matches #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aywrite wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ci(ci): Add a candidate clock to the Strength workflow for time odds matches #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/strength-batch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,12 @@ on:
description: Passed to fastchess as tc.
type: string
required: true
candidate_time_control:
description: >
A clock for the candidate alone, which makes this a time odds match.
Empty gives both sides time_control.
type: string
default: ""
sprt:
description: Judge a sequential test over the pooled pairs.
type: boolean
Expand Down Expand Up @@ -144,6 +150,7 @@ jobs:
BATCH: ${{ inputs.batch }}
BATCHES: ${{ inputs.batches }}
TIME_CONTROL: ${{ inputs.time_control }}
CANDIDATE_TIME_CONTROL: ${{ inputs.candidate_time_control }}
BOOK: ${{ inputs.book }}
SPRT: ${{ inputs.sprt }}
ELO0: ${{ inputs.elo0 }}
Expand Down Expand Up @@ -184,7 +191,7 @@ jobs:
scripts/build_at.sh "$CANDIDATE_SHA" tools/new
scripts/build_at.sh "$BASELINE_SHA" tools/old

- uses: aywrite/mache/actions/play-shard@e3a59ce295c9dfabb62ddb077e88606d022cc55d # v0.7.1
- uses: aywrite/mache/actions/play-shard@10f17c5120bb58dfacf2304532bbc63aef86fabe # unreleased, aywrite/mache#35
id: play
with:
candidate: ${{ inputs.candidate_name }}
Expand All @@ -200,6 +207,7 @@ jobs:
batch: ${{ inputs.batch }}
batches: ${{ inputs.batches }}
time_control: ${{ inputs.time_control }}
candidate_time_control: ${{ inputs.candidate_time_control }}
hash_mb: ${{ inputs.hash_mb }}
concurrency: ${{ inputs.concurrency }}
startup_ms: ${{ inputs.startup_ms }}
Expand Down Expand Up @@ -241,7 +249,11 @@ jobs:
echo "shard: ${SHARD}"
echo "start: ${START:-not chosen, the shard did not get that far}"
echo "pairs: ${PAIRS}"
echo "time_control: ${TIME_CONTROL}"
if [ -n "$CANDIDATE_TIME_CONTROL" ]; then
echo "time_control: ${TIME_CONTROL} for the baseline, ${CANDIDATE_TIME_CONTROL} for the candidate"
else
echo "time_control: ${TIME_CONTROL}"
fi
echo "hash_mb: ${HASH}"
echo "concurrency: ${CONCURRENCY}"
echo "startup_ms: ${STARTUP_MS}"
Expand Down Expand Up @@ -319,7 +331,8 @@ jobs:
baseline: ${{ inputs.baseline_name }}
baseline_sha: ${{ inputs.baseline_sha }}
shards: ${{ inputs.count }}
time_control: ${{ inputs.time_control }}
# what the summary prints, so a time odds match says so
time_control: ${{ inputs.candidate_time_control && format('{0} against {1}', inputs.candidate_time_control, inputs.time_control) || inputs.time_control }}
sprt: ${{ inputs.sprt }}
elo0: ${{ inputs.elo0 }}
elo1: ${{ inputs.elo1 }}
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/strength.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ on:
description: The table both sides are given, in MB. 256 is what the engine defaults to. A smaller table puts the replacement policy under the pressure a longer game would, and figures at different sizes are not comparable.
type: number
default: 256
candidate_time_control:
description: A clock for the candidate alone, for a time odds match, where the same build plays itself with one side given more time. The baseline plays time_control. Left empty both sides play time_control.
type: string
default: ""
workflow_call:
inputs:
candidate:
Expand Down Expand Up @@ -112,6 +116,9 @@ on:
hash_mb:
type: number
default: 256
candidate_time_control:
type: string
default: ""
publish:
description: Append the result to the release notes for this tag
type: boolean
Expand Down Expand Up @@ -260,6 +267,7 @@ jobs:
# each other's openings
seed: ${{ inputs.seed || github.run_id }}
time_control: ${{ inputs.time_control }}
candidate_time_control: ${{ inputs.candidate_time_control }}
sprt: ${{ fromJSON(needs.resolve.outputs.sprt) }}
elo0: ${{ fromJSON(needs.resolve.outputs.elo0) }}
elo1: ${{ fromJSON(needs.resolve.outputs.elo1) }}
Expand Down Expand Up @@ -290,6 +298,7 @@ jobs:
book: ${{ needs.resolve.outputs.book }}
seed: ${{ inputs.seed || github.run_id }}
time_control: ${{ inputs.time_control }}
candidate_time_control: ${{ inputs.candidate_time_control }}
sprt: ${{ fromJSON(needs.resolve.outputs.sprt) }}
elo0: ${{ fromJSON(needs.resolve.outputs.elo0) }}
elo1: ${{ fromJSON(needs.resolve.outputs.elo1) }}
Expand Down Expand Up @@ -320,6 +329,7 @@ jobs:
book: ${{ needs.resolve.outputs.book }}
seed: ${{ inputs.seed || github.run_id }}
time_control: ${{ inputs.time_control }}
candidate_time_control: ${{ inputs.candidate_time_control }}
sprt: ${{ fromJSON(needs.resolve.outputs.sprt) }}
elo0: ${{ fromJSON(needs.resolve.outputs.elo0) }}
elo1: ${{ fromJSON(needs.resolve.outputs.elo1) }}
Expand Down Expand Up @@ -350,6 +360,7 @@ jobs:
book: ${{ needs.resolve.outputs.book }}
seed: ${{ inputs.seed || github.run_id }}
time_control: ${{ inputs.time_control }}
candidate_time_control: ${{ inputs.candidate_time_control }}
sprt: ${{ fromJSON(needs.resolve.outputs.sprt) }}
elo0: ${{ fromJSON(needs.resolve.outputs.elo0) }}
elo1: ${{ fromJSON(needs.resolve.outputs.elo1) }}
Expand Down
Loading