Skip to content

error-fn-test: make processing order clearer #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borkdude merged 1 commit into from
Sep 25, 2026
Merged

error-fn-test: make processing order clearer #236

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions test/babashka/cli_test.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1616,15 +1616,19 @@
{:error-fn (fn [error] (swap! errors conj error))
:restrict true
:spec spec})
(is (= [{:spec spec, :type :org.babashka/cli, :cause :coerce,
(is (= [{:spec spec, :type :org.babashka/cli, :cause :validate,
:msg "Invalid value for option --b: 0", :validate {:b pos?}, :option :b, :flag "--b", :value 0,
:opts {:b 0, :extra "bad!"}}
{:spec spec, :type :org.babashka/cli, :cause :coerce,
:msg "Invalid value for option --c: cannot transform input \"nope!\" to long", :option :c, :flag "--c",
:value "nope!", :opts {:b 0}}
{:spec spec, :type :org.babashka/cli, :cause :restrict, :msg "Unknown option: --extra", :restrict #{:c :b :a}, :option :extra, :flag "--extra", :opts {:b 0, :extra "bad!"}}
;; :require has no :flag in data (never typed); the message uses the canonical --a
{:spec spec, :type :org.babashka/cli, :cause :require, :msg "Required option: --a", :require #{:a}, :option :a, :opts {:b 0, :extra "bad!"}}
{:spec spec, :type :org.babashka/cli, :cause :validate, :msg "Invalid value for option --b: 0", :validate {:b pos?}, :option :b, :flag "--b", :value 0,
:opts {:b 0, :extra "bad!"}}]
@errors))))
{:spec spec, :type :org.babashka/cli, :cause :require,
:msg "Required option: --a", :require #{:a}, :option :a, :opts {:b 0, :extra "bad!"}}
{:spec spec, :type :org.babashka/cli, :cause :restrict,
:msg "Unknown option: --extra", :restrict #{:c :b :a}, :option :extra, :flag "--extra", :opts {:b 0, :extra "bad!"}}]
;; processing order, and therefore collected errors order, is indeterminate
(sort-by :msg @errors)))))

(deftest exec-args-replaced-test
(is (= {:foo [:bar] :dude [:baz]} (cli/parse-opts ["--foo" ":bar"] {:coerce {:foo [] :dude []}
Expand Down
Loading