Repository navigation
Conversation
Sync snapshot contents before rename and the destination directory before reporting success. This covers local snapshots and snapshots received from peers, and lets existing failure paths prevent compaction on sync errors. Add regression coverage for publication ordering and file/directory sync failures, including the forked serializer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A successful snapshot serialization allows PySyncObj to compact the journal. On POSIX, snapshot publication currently uses
os.rename()without syncing the file or directory. An abrupt shutdown can therefore leave an empty or stale snapshot alongside an already compacted journal, preventing recovery.Sync the temporary snapshot before renaming it, then sync the destination directory before reporting success. This covers both locally generated and received snapshots. Sync errors propagate through the existing failure handlers, preventing journal compaction when persistence fails.
Validation: