feat: make the game case responsive - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed-width case overflowed narrow screens. Scale the complete case to its container width, capped at its original 664 × 940 size, so the artwork, canvas, and Start/On button stay aligned.
An aspect-ratio wrapper reserves the displayed height. The bottom observer and fade stay outside the scaled element, and the fade remains anchored to the viewport. Pixi retains its 400 × 300 internal resolution.
Validation:
npm run checkandnpm run buildpass. Browser checks at 320px, 390px, 768px, and 1440px confirmed proportional sizing without horizontal page overflow. Clicking the scaled Start/On button starts the game; no browser errors were reported.Uses CSS container units and typed division in
calc()for scaling. The existing Vite large-chunk warning remains.